Skip to content

Tornado typeshed lacks HTTPClientError class; status of Tornado typeshed #4318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shamrin opened this issue Jul 8, 2020 · 2 comments
Closed

Comments

@shamrin
Copy link

shamrin commented Jul 8, 2020

Tornado typeshed doesn't provide tornado.httpclient.HTTPClientError class, only the deprecated HTTPError:

class HTTPError(Exception):

It was introduced in Tornado 5.1:

Changed in version 5.1: Renamed from HTTPError to HTTPClientError to avoid collisions with tornado.web.HTTPError. The name tornado.httpclient.HTTPError remains as an alias.

Separately, what is the status of Tornado typeshed? Tornado provides high-quality inline types. Are there cases where typeshed is preferable to inline types?

Related issue: microsoft/pyright#813

@shamrin shamrin changed the title Tornado typeshed misses HTTPClientError class; status of Tornado typeshed Tornado typeshed lacks HTTPClientError class; status of Tornado typeshed Jul 8, 2020
@srittau
Copy link
Collaborator

srittau commented Jul 9, 2020

Good to hear that tornado now ships their own annotations. We should just remove it from typeshed. I will open a PR.

@JelleZijlstra
Copy link
Member

Fixed by #4321.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants