Skip to content

subprocess needs to be updated for python 3.5 #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wreed4 opened this issue Aug 4, 2016 · 9 comments
Closed

subprocess needs to be updated for python 3.5 #437

wreed4 opened this issue Aug 4, 2016 · 9 comments

Comments

@wreed4
Copy link
Contributor

wreed4 commented Aug 4, 2016

They added a "run" method in 3.5. Because this stub is out of date, mypy doesn't know about this "run" method.

@gvanrossum
Copy link
Member

gvanrossum commented Aug 4, 2016 via email

@wreed4
Copy link
Contributor Author

wreed4 commented Aug 4, 2016

I'd just change the .pyi file in stdlib/3, right? Wouldn't make one in stdlib/3.5?

@gvanrossum
Copy link
Member

gvanrossum commented Aug 4, 2016 via email

@wreed4
Copy link
Contributor Author

wreed4 commented Aug 4, 2016

There's also the CompletedProcess object and the DEVNULL attribute (added in 3.3). Should these be added under a sys.version_info check as well?

@gvanrossum
Copy link
Member

Might as well clean it up...

@wreed4
Copy link
Contributor Author

wreed4 commented Aug 4, 2016

sorry if this is a dumb question, but is that a yes? or are you saying I shouldn't submit a pull request and you'll clean it up?

@gvanrossum
Copy link
Member

Sorry, that was a yes!

@jdelic
Copy link
Contributor

jdelic commented Aug 5, 2016

I just want to mention that I'm working on a more elaborate update in #426

@JelleZijlstra
Copy link
Member

subprocess.run is in the stub now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants