-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
subprocess needs to be updated for python 3.5 #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for noticing! Do you feel up to submitting a PR? It should probably
check for sys.version_info.
…--Guido (mobile)
|
I'd just change the .pyi file in stdlib/3, right? Wouldn't make one in stdlib/3.5? |
Correct, no new file.
…--Guido (mobile)
|
There's also the CompletedProcess object and the DEVNULL attribute (added in 3.3). Should these be added under a sys.version_info check as well? |
Might as well clean it up... |
sorry if this is a dumb question, but is that a yes? or are you saying I shouldn't submit a pull request and you'll clean it up? |
Sorry, that was a yes! |
I just want to mention that I'm working on a more elaborate update in #426 |
|
They added a "run" method in 3.5. Because this stub is out of date, mypy doesn't know about this "run" method.
The text was updated successfully, but these errors were encountered: