Skip to content

stubtest on windows isn't doing anything #4448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hauntsaninja opened this issue Aug 15, 2020 · 7 comments · Fixed by #4455
Closed

stubtest on windows isn't doing anything #4448

hauntsaninja opened this issue Aug 15, 2020 · 7 comments · Fixed by #4455
Labels
project: infrastructure typeshed build, test, documentation, or distribution related

Comments

@hauntsaninja
Copy link
Collaborator

I think this has been the case for a while, I suspect since they were moved to Github actions in #4223
Example in #4447

@srittau
Copy link
Collaborator

srittau commented Aug 17, 2020

@hauntsaninja Do you have any idea why that might be? The output (example) indicates a successful run.

@srittau srittau added the project: infrastructure typeshed build, test, documentation, or distribution related label Aug 17, 2020
@JelleZijlstra
Copy link
Member

I put some debug prints in #4454 and apparently we just never execute any part of stubtest_test.py. There must be something wrong with how we invoke the script in the GitHub action (https://github.com/python/typeshed/blob/master/.github/workflows/stubtest.yml#L27).

@Akuli
Copy link
Collaborator

Akuli commented Aug 17, 2020

This runs the script correctly on windows and ubuntu: 2dc3d10

but after adding that, stubtest fails to import something on windows: https://github.com/Akuli/typeshed/runs/994228956

@srittau
Copy link
Collaborator

srittau commented Aug 17, 2020

Makes sense that it didn't run with Python, since I assume that the default Windows shell doesn't look at the hashbang. It's just strange that there were no errors reported.

@Akuli
Copy link
Collaborator

Akuli commented Aug 17, 2020

welcome to windows lol

@hauntsaninja
Copy link
Collaborator Author

Thanks for figuring it out Akuli! It looks like we removed dbm.ndbm from the whitelists in #4225, shortly after moving to Github Action. I opened #4455, since stubtest should print "stubtest succeeded" we'll be able to figure out if it ran.

@Akuli
Copy link
Collaborator

Akuli commented Aug 17, 2020

maybe put it to tests/stubtest_whitelists/win32.txt? dbm.gnu is already there

edit: nevermind you put it there already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: infrastructure typeshed build, test, documentation, or distribution related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants