Skip to content

pallet projects get type hints: Click, Werkzeug, MarkupSafe, ItsDangerous, Flask, Jinja #5337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Akuli opened this issue May 4, 2021 · 2 comments
Labels
stubs: removal Pending removal of third-party distributions

Comments

@Akuli
Copy link
Collaborator

Akuli commented May 4, 2021

I asked on pallets projects discord:

The next versions of all 6 projects will be released in a few weeks, and they'll all be fully typed and provide the py.typed marker. Click, Werkzeug, MarkupSafe, ItsDangerous, and Flask are done already, and I'm working on Jinja right now.

I was going to open an issue in typeshed notifying about this once they were released. It's my understanding that py.typed will be preferred over typeshed, and typeshed will drop support after 6-12 months.

For now, should we keep accepting pull requests for these projects or just tell people to wait?

@Akuli Akuli added the stubs: removal Pending removal of third-party distributions label May 4, 2021
@srittau
Copy link
Collaborator

srittau commented May 4, 2021

It's fine to accept PRs still.

@Akuli
Copy link
Collaborator Author

Akuli commented May 12, 2021

Duplicate of #5423

@Akuli Akuli marked this as a duplicate of #5423 May 12, 2021
@Akuli Akuli closed this as completed May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stubs: removal Pending removal of third-party distributions
Projects
None yet
Development

No branches or pull requests

2 participants