Skip to content

click: should _PathType allow pathlib.Path? #5917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
remexre opened this issue Aug 12, 2021 · 2 comments
Closed

click: should _PathType allow pathlib.Path? #5917

remexre opened this issue Aug 12, 2021 · 2 comments

Comments

@remexre
Copy link

remexre commented Aug 12, 2021

https://github.com/python/typeshed/blob/master/stubs/click/click/types.pyi#L73

https://github.com/pallets/click/blob/main/src/click/types.py#L767-L769
@JelleZijlstra
Copy link
Member

The usage of the TypeVar dooesn't make a ton of sense to me since it's not in a generic class. Maybe it should instead use one of the aliases from _typeshed.

@Akuli
Copy link
Collaborator

Akuli commented Dec 2, 2021 •
edited
Loading

We no longer have stubs for pallets projects (including click). #5423

@Akuli Akuli closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JelleZijlstra @remexre @Akuli