Skip to content

Limit regression test workers to 1 #11344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Jan 30, 2024

This should address #11220.

@srittau
Copy link
Collaborator Author

srittau commented Jan 30, 2024

It's fairly slow now. I wonder whether we could reduce the amount of tests run. For example, run only on Python 3.8 and 3.12. In the long run it could also make sense to separate out tests that need to run on multiple platforms or Python versions as currently we are running lots of redundant tests.

@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 30, 2024

And/or we can shard it.

I'm also experimenting locally with whether adding the --no-incremental flag fixes things, since the race condition (if it is a race condition) is likely due to different mypys concurrently trying to read the same cache. --no-incremental will probably make running with --all a fair bit slower locally, but probably won't make much difference in CI, so it's probably a pretty good tradeoff (I doubt many people run with --all much locally anyway; I certainly don't).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants