Skip to content

refleak in typing.py #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gvanrossum opened this issue Nov 9, 2016 · 5 comments
Closed

refleak in typing.py #323

gvanrossum opened this issue Nov 9, 2016 · 5 comments

Comments

@gvanrossum
Copy link
Member

gvanrossum commented Nov 9, 2016

This is a proxy for http://bugs.python.org/issue28649, which is discussing a reference leak (real or perceived) caused (most likely) by the use of lru_cache. There's a small fix there that we should apply here (if it gets applied to CPython): http://bugs.python.org/review/28649/#ps19113; and another at http://bugs.python.org/review/28649/. Also I think the fixes should be back-ported (the Python 2 version uses its own cache implementation which presumably should also be cleared when testing for refleaks).

@ilevkivskyi
Copy link
Member

@gvanrossum I think we should also apply http://bugs.python.org/review/28649/#ps19114 to avoid problems in the future.

@ilevkivskyi
Copy link
Member

@gvanrossum Oh, sorry, you already mentioned this one. :-) Will submit a corrected patch now.

@gvanrossum
Copy link
Member Author

gvanrossum commented Nov 9, 2016 via email

@gvanrossum
Copy link
Member Author

Note that we have at least 5 PRs related to this issue (now all merged): #324, #325, #326, #327, #328. Wow.

@ilevkivskyi
Copy link
Member

The original refleak is fixed and it looks like there are no signs of other leaks almost one month since the release, so that I think this issue could be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants