Fix #255 - Add phone number validation to sign form #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… validate Signature's phone + create test
Benbb96
commented
Aug 20, 2022
fallen
requested changes
Aug 22, 2022
Member
fallen
left a comment
fallen
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution, it looks really good!
Clean, working fine, and has a test.
Please just modify the few nitpicks and it's OK for merging afterward :)
Contributor
Author
|
Thanks for the review. I've applied requested changes ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #255
I added the django-phonenumber-field library in order to validate Signature's
phonefield.