Skip to content

Conversation

@jeffydc
Copy link
Contributor

@jeffydc jeffydc commented May 6, 2021

Description

Fix #104
Part of #103

Add a sidebar coming from left to right for left pane on mobile. There is a hamburger button in the bottom right of the window.

Additional context

Since the navigation and left pane are in each different components, it is difficult to put menu on navigation bar.
Instead I put the menu in the bottom right place of the window. That place could be helpful for full screen smartphones and one-handed users.
The place is inspired by https://reactjs.org/docs/ when viewing on mobile.


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

@jeffydc jeffydc added the enhancement New feature or request label May 6, 2021
@jeffydc jeffydc requested review from trsvchn and vfdev-5 May 6, 2021 09:29
@netlify
Copy link

netlify bot commented May 6, 2021

Deploy preview for code-generator ready!

Built with commit a9b2741

https://deploy-preview-108--code-generator.netlify.app

@jeffydc jeffydc linked an issue May 6, 2021 that may be closed by this pull request
@jeffydc jeffydc mentioned this pull request May 6, 2021
23 tasks
Copy link
Member

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ydcjeff perfect !

@jeffydc jeffydc changed the title feat: add sidebar for left pane on mobile feat: add sidebar for left pane for mobile May 6, 2021
@jeffydc jeffydc merged commit c7642df into v1 May 6, 2021
@jeffydc jeffydc deleted the sidebar branch May 6, 2021 11:17
Copy link
Member

@trsvchn trsvchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ydcjeff looks neat!

jeffydc added a commit that referenced this pull request May 21, 2021
* feat: add sidebar for left pane on mobile

* feat: add box shadow for white bg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make app looks good on mobile

4 participants