Skip to content

fix: revert back to previous app UX #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2021
Merged

fix: revert back to previous app UX #126

merged 1 commit into from
May 20, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented May 20, 2021

Description

This PR makes the app

  • have default value in output_dir and log_every_iters
  • distributed training checkbox
  • distributed default values (nproc_per_node, nnodes, master_addr, and master_port)
  • updated READMEs
  • updated config.yaml

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

- have default value in `output_dir` and `log_every_iters`
- distributed training checkbox
- distributed default values (`nproc_per_node`, `nnodes`, `master_addr`, and `master_port`)
- updated READMEs
- updated config.yaml
@ydcjeff ydcjeff added the bug Something isn't working label May 20, 2021
@ydcjeff ydcjeff requested a review from vfdev-5 May 20, 2021 14:22
@netlify
Copy link

netlify bot commented May 20, 2021

Deploy Preview for code-generator ready!

Built with commit fa36634

https://deploy-preview-126--code-generator.netlify.app

@ydcjeff ydcjeff changed the title fix: change back to have previous UI fix: revert back to previous UX May 20, 2021
@ydcjeff ydcjeff changed the title fix: revert back to previous UX fix: revert back to previous app UX May 20, 2021
@ydcjeff ydcjeff merged commit 69f01ed into main May 20, 2021
@ydcjeff ydcjeff deleted the ui-fix branch May 20, 2021 15:07
ydcjeff added a commit that referenced this pull request May 21, 2021
- have default value in `output_dir` and `log_every_iters`
- distributed training checkbox
- distributed default values (`nproc_per_node`, `nnodes`, `master_addr`, and `master_port`)
- updated READMEs
- updated config.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant