Skip to content

fix: download after template, move download & colab under each left tab #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 17, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Jun 11, 2021

Description

ref: #103 (comment)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

@ydcjeff ydcjeff added the bug Something isn't working label Jun 11, 2021
@ydcjeff ydcjeff requested a review from vfdev-5 June 11, 2021 03:34
@netlify
Copy link

netlify bot commented Jun 11, 2021

✔️ Deploy Preview for code-generator ready!

🔨 Explore the source changes: 3cfce6d

🔍 Inspect the deploy log: https://app.netlify.com/sites/code-generator/deploys/60cb289fd0a904000765b716

😎 Browse the preview: https://deploy-preview-161--code-generator.netlify.app/

@vfdev-5
Copy link
Member

vfdev-5 commented Jun 11, 2021

@ydcjeff let's move download and colab somewhere else instead of removing others.

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Jun 11, 2021

Where shall we move?

@vfdev-5
Copy link
Member

vfdev-5 commented Jun 11, 2021

For example, in the end of left widget

@vfdev-5
Copy link
Member

vfdev-5 commented Jun 11, 2021

@ydcjeff this is nicer ! How about splitting left widget into 2 such "download" and "open in colab" are visible from any tab : templates, training, handlers, loggers ?

@trsvchn
Copy link
Member

trsvchn commented Jun 11, 2021

yes, can we anchor them?

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Jun 11, 2021

@ydcjeff this is nicer ! How about splitting left widget into 2 such "download" and "open in colab" are visible from any tab : templates, training, handlers, loggers ?

I have tried to appear them in any tab. But contents in handler tab are long and seems not having enough space for content in handler tab and many spaces are left in the rest of the tabs.

Putting under each tab looks also good.

@ydcjeff ydcjeff changed the title fix: download after template, remove twitter & discord fix: download after template, move download & colab under each left tab Jun 11, 2021
@ydcjeff ydcjeff requested a review from trsvchn June 11, 2021 10:16
@trsvchn
Copy link
Member

trsvchn commented Jun 11, 2021

Ok, looks not that nice. What about anchoring on the top, because tabs have different "height" and buttons float out of the viewing field

@trsvchn
Copy link
Member

trsvchn commented Jun 17, 2021

It is definitely better on the top, but not sure if it is the perfect place :(

@ydcjeff ydcjeff merged commit 0677621 into main Jun 17, 2021
@ydcjeff ydcjeff deleted the fix/103-cmt branch June 17, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants