Skip to content

feat: allow users give project name #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2021
Merged

feat: allow users give project name #35

merged 2 commits into from
Apr 3, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Apr 2, 2021

Description: Allow users to give project name which is used as package name as well

@ydcjeff ydcjeff requested a review from trsvchn April 2, 2021 13:05
@ydcjeff ydcjeff merged commit 07b1115 into master Apr 3, 2021
@ydcjeff ydcjeff deleted the project-input branch April 3, 2021 10:39
@trsvchn
Copy link
Member

trsvchn commented Apr 3, 2021

Thank @ydcjeff! I've tested it locally, and it works fine!

@ydcjeff ydcjeff added enhancement New feature or request frontend Vue app labels Apr 3, 2021
@ydcjeff ydcjeff added this to the v0.1.0 milestone Apr 3, 2021
@vfdev-5
Copy link
Member

vfdev-5 commented Apr 3, 2021

@ydcjeff there can be an issue if user rename the project something like project-abc and imports like below wont work IMO

from project-abc.trainers import create_trainers, TrainEvents
from project-abc.handlers import get_handlers, get_logger
from project-abc.utils import setup_logging, log_metrics, log_basic_info, initialize, resume_from
from project-abc.config import get_default_parser

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Apr 4, 2021

Yes, that won't work
Users need to give with underscore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Vue app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants