Skip to content

Commit e5c84d7

Browse files
committed
wip
1 parent c5a7077 commit e5c84d7

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

.github/scripts/fbgemm_gpu_build.bash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ __configure_fbgemm_gpu_build_nvcc () {
118118
}
119119

120120
__configure_fbgemm_gpu_cuda_home () {
121-
if [[ "$BUILD_CUDA_VERSION" =~ ^12.6.*$ ]]; then
121+
if ! [[ "$BUILD_CUDA_VERSION" =~ ^11.*$ ]]; then
122122
# shellcheck disable=SC2155,SC2086
123123
local conda_prefix=$(conda run ${env_prefix} printenv CONDA_PREFIX)
124124
local new_cuda_home="${conda_prefix}/targets/${MACHINE_NAME_LC}-linux"

.github/scripts/utils_build.bash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ __remove_gcc_activation_scripts () {
179179
# https://stackoverflow.com/questions/64289376/how-to-circumvent-anaconda-gcc-compiler
180180
#
181181
# shellcheck disable=SC2155,SC2086
182-
if [[ "$BUILD_CUDA_VERSION" =~ ^12.6.*$ ]]; then
182+
if ! [[ "$BUILD_CUDA_VERSION" =~ ^11.*$ ]]; then
183183
echo "[INSTALL] Removing GCC package activation scripts ..."
184184
local conda_prefix=$(conda run ${env_prefix} printenv CONDA_PREFIX)
185185
print_exec ls -la ${conda_prefix}/etc/conda/activate.d

.github/scripts/utils_cuda.bash

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ __set_cuda_symlinks_envvars () {
1818
local conda_prefix=$(conda run ${env_prefix} printenv CONDA_PREFIX)
1919
local new_cuda_home="${conda_prefix}/targets/${MACHINE_NAME_LC}-linux"
2020

21-
if [[ "$BUILD_CUDA_VERSION" =~ ^12.6.*$ ]]; then
21+
if ! [[ "$BUILD_CUDA_VERSION" =~ ^11.*$ ]]; then
2222
# CUDA 12.6 installation has a very different package layout than previous
2323
# CUDA versions - notably, NVTX has been moved elsewhere, which causes
2424
# PyTorch CMake scripts to complain.
@@ -89,7 +89,7 @@ __set_nvcc_prepend_flags () {
8989
# which overrides whatever `-ccbin` flag we set manually, so remove this
9090
# unwanted hook
9191
print_exec ls -la "${conda_prefix}/etc/conda/activate.d"
92-
if [[ "$BUILD_CUDA_VERSION" =~ ^12.6.*$ ]]; then
92+
if ! [[ "$BUILD_CUDA_VERSION" =~ ^11.*$ ]]; then
9393
echo "[INSTALL] Removing the -ccbin=CXX hook from NVCC activation scripts ..."
9494
print_exec sed -i '/-ccbin=/d' "${conda_prefix}/etc/conda/activate.d/*cuda-nvcc_activate.sh"
9595
fi
@@ -192,14 +192,14 @@ install_cuda () {
192192
# in the future, we will be using conda-forge for installing all CUDA versions
193193
# (except for versions 11.8 and below, which are only available through
194194
# nvidia/label/cuda-*)
195-
if [[ "$BUILD_CUDA_VERSION" =~ ^12.6.*$ ]]; then
196-
# shellcheck disable=SC2086
197-
(exec_with_retries 3 conda install --force-reinstall ${env_prefix} -c conda-forge --override-channels -y \
198-
cuda=${cuda_version}) || return 1
199-
else
195+
if [[ "$BUILD_CUDA_VERSION" =~ ^11.*$ ]]; then
200196
# shellcheck disable=SC2086
201197
(exec_with_retries 3 conda install --force-reinstall ${env_prefix} -c "nvidia/label/cuda-${cuda_version}" -y \
202198
cuda) || return 1
199+
else
200+
# shellcheck disable=SC2086
201+
(exec_with_retries 3 conda install --force-reinstall ${env_prefix} -c conda-forge --override-channels -y \
202+
cuda=${cuda_version}) || return 1
203203
fi
204204

205205
# Set the symlinks and environment variables not covered by conda install

.github/workflows/fbgemm_gpu_pip.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,5 +241,5 @@ jobs:
241241
run: . $PRELUDE; install_fbgemm_gpu_pip $BUILD_ENV ${{ github.event.inputs.fbgemm_gpu_channel_version || 'nightly' }} rocm/${{ matrix.rocm-version }}
242242

243243
- name: Test with PyTest
244-
timeout-minutes: 20
244+
timeout-minutes: 40
245245
run: . $PRELUDE; test_all_fbgemm_gpu_modules $BUILD_ENV

0 commit comments

Comments
 (0)