Skip to content

Commit ef57c05

Browse files
trieuatfacebook-github-bot
authored andcommitted
Support histogram_binning_calibration for export (#3657)
Summary: X-link: facebookresearch/FBGEMM#733 Add fake tensor for `histogram_binning_calibration` which is needed to export old PA. Reviewed By: hongyang-zhao Differential Revision: D69089371
1 parent 321af91 commit ef57c05

File tree

2 files changed

+29
-4
lines changed

2 files changed

+29
-4
lines changed

fbgemm_gpu/fbgemm_gpu/sparse_ops.py

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1100,6 +1100,27 @@ def fused_8_bit_rowwise_quantized_to_half(
11001100
return torch.empty(output_shape, dtype=torch.float16, device=input_t.device)
11011101

11021102

1103+
def generic_histogram_binning_calibration_by_feature(
1104+
logit: Tensor,
1105+
segment_value: Tensor,
1106+
segment_lengths: Tensor,
1107+
num_segments: int,
1108+
bin_num_examples: Tensor,
1109+
bin_num_positives: Tensor,
1110+
bin_boundaries: Tensor,
1111+
positive_weight: float,
1112+
bin_ctr_in_use_after: int,
1113+
bin_ctr_weight_value: float,
1114+
) -> Tuple[Tensor, Tensor]:
1115+
torch._check(bin_num_examples.numel() == bin_num_positives.numel())
1116+
torch._check(
1117+
bin_num_examples.numel() == (num_segments + 1) * (bin_boundaries.numel() + 1)
1118+
)
1119+
return torch.empty_like(logit), torch.empty(
1120+
[logit.numel()], dtype=torch.int64, device=logit.device
1121+
)
1122+
1123+
11031124
def _setup() -> None:
11041125
# pyre-ignore[16]
11051126
_setup.done = getattr(_setup, "done", False)
@@ -1233,6 +1254,10 @@ def impl_autograd(op_name, fn, setup_context: Optional[Callable] = None) -> None
12331254
"fbgemm::histogram_binning_calibration",
12341255
histogram_binning_calibration_abstract,
12351256
)
1257+
impl_abstract(
1258+
"fbgemm::generic_histogram_binning_calibration_by_feature",
1259+
generic_histogram_binning_calibration_by_feature,
1260+
)
12361261
impl_abstract(
12371262
"fbgemm::FloatToHFP8Quantized",
12381263
float_to_hfp8_quantized,

fbgemm_gpu/test/sparse/failures_dict.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,19 +141,19 @@
141141
"fbgemm::generic_histogram_binning_calibration_by_feature": {
142142
"HistogramBinningCalibrationTest.test_aot_dispatch_dynamic__test_generic_histogram_binning_calibration_by_feature": {
143143
"comment": "",
144-
"status": "xfail"
144+
"status": "xsuccess"
145145
},
146146
"HistogramBinningCalibrationTest.test_aot_dispatch_dynamic__test_generic_histogram_binning_calibration_by_feature_cpu_gpu": {
147147
"comment": "",
148-
"status": "xfail"
148+
"status": "xsuccess"
149149
},
150150
"HistogramBinningCalibrationTest.test_faketensor__test_generic_histogram_binning_calibration_by_feature": {
151151
"comment": "",
152-
"status": "xfail"
152+
"status": "xsuccess"
153153
},
154154
"HistogramBinningCalibrationTest.test_faketensor__test_generic_histogram_binning_calibration_by_feature_cpu_gpu": {
155155
"comment": "",
156-
"status": "xfail"
156+
"status": "xsuccess"
157157
}
158158
},
159159
"fbgemm::group_index_select_dim0": {

0 commit comments

Comments
 (0)