Skip to content

Commit f12f75e

Browse files
sryapfacebook-github-bot
authored andcommitted
Fix flaky TBE unit tests (#3938)
Summary: X-link: facebookresearch/FBGEMM#1023 As title Reviewed By: spcyppt Differential Revision: D72595672
1 parent e4905d3 commit f12f75e

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

fbgemm_gpu/test/tbe/bench/tbe_data_config_models_test.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
PoolingParams,
1919
TBEDataConfig,
2020
)
21-
from hypothesis import given
21+
from hypothesis import given, settings
2222

2323

2424
def rand_int(min_value: int, max_value: int) -> int:
@@ -30,6 +30,7 @@ class TBEDataConfigModelsTest(unittest.TestCase):
3030
@given(
3131
dtype=st.sampled_from([torch.float32, torch.float64]),
3232
)
33+
@settings(deadline=None)
3334
def test_indices_params_serialization(
3435
self,
3536
dtype: torch.dtype,
@@ -57,6 +58,7 @@ def test_pooling_params_serialization(self) -> None:
5758
@given(
5859
dtype=st.sampled_from([torch.float32, torch.float64]),
5960
)
61+
@settings(deadline=None)
6062
def test_tbe_data_config_serialization(
6163
self,
6264
dtype: torch.dtype,

fbgemm_gpu/test/tbe/training/failures_dict_fast.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"fbgemm::Fused8BitRowwiseQuantizedToFloat": {},
77
"fbgemm::asynchronous_complete_cumsum": {},
88
"fbgemm::bounds_check_indices": {},
9+
"fbgemm::check_feature_gate_key": {},
910
"fbgemm::dense_embedding_codegen_lookup_function": {
1011
"BackwardDenseTest.test_autograd_registration__test_backward_dense": {
1112
"comment": "",
@@ -24,6 +25,7 @@
2425
}
2526
},
2627
"fbgemm::emb_inplace_update": {},
28+
"fbgemm::get_infos_metadata": {},
2729
"fbgemm::get_unique_indices": {
2830
"LXUCacheTest.test_faketensor__test_unique_lxu_cache_lookup": {
2931
"comment": "",
@@ -363,6 +365,7 @@
363365
"fbgemm::split_embedding_codegen_forward_weighted_cuda": {},
364366
"fbgemm::split_embedding_codegen_lookup_adagrad_function": {},
365367
"fbgemm::split_embedding_codegen_lookup_adagrad_function_cpu": {},
368+
"fbgemm::split_embedding_codegen_lookup_adagrad_function_pt2": {},
366369
"fbgemm::split_embedding_codegen_lookup_adam_function": {},
367370
"fbgemm::split_embedding_codegen_lookup_lamb_function": {},
368371
"fbgemm::split_embedding_codegen_lookup_lars_sgd_function": {},
@@ -381,10 +384,6 @@
381384
},
382385
"fbgemm::split_embedding_codegen_lookup_rowwise_adagrad_function_cpu": {},
383386
"fbgemm::split_embedding_codegen_lookup_rowwise_adagrad_function_pt2": {
384-
"BackwardAdagradTest.test_faketensor__test_backward_adagrad_fp32_cpu": {
385-
"comment": "",
386-
"status": "xfail"
387-
},
388387
"ForwardTest.test_faketensor__test_forward_cpu_fp32": {
389388
"comment": "",
390389
"status": "xfail"

0 commit comments

Comments
 (0)