Commit 77dc2ca
committed
fix float8 training TP+SP integration tests
Summary:
These tests do not run in CI, and they broke some time ago. The issue
was that each tensor was created on "cuda:0" instead of using the local
rank. For now, fixing by manually specifying the rank. I feel like there
is probably a better way to do this as the rank is supposed to be set
automatically, but leaving that for a future PR.
We should add to CI in the future, saving that for a future PR.
Test Plan:
```bash
./test/float8/test_dtensor.sh
```
Reviewers:
Subscribers:
Tasks:
Tags:
ghstack-source-id: 39bd880
ghstack-comment-id: 2991778315
Pull Request resolved: #24141 parent 4e3d019 commit 77dc2ca
2 files changed
+4
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
| 71 | + | |
70 | 72 | | |
71 | 73 | | |
72 | 74 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
| 50 | + | |
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
| |||
0 commit comments