From 97641f965040eb0c5d408a4a541e1d5a98317cfd Mon Sep 17 00:00:00 2001 From: Jesse Cai Date: Wed, 24 Jul 2024 10:43:00 -0700 Subject: [PATCH 1/3] Fix regression tests Summary: Torch 2.2 is compiled with numpy 1.x, but when we `pip install -r requirements-dev.txt` we download a higher version of numpy (2.0) This causes an error with the .numpy() calls and importing torch in general. I don't think we want to pin the versions in requirements-dev.txt, so instead I added a pin to the numpy version in the specific torch spec, so it'll only run for 2.2. PT 2.3+ support numpy 2.0+ which is why those test don't fail. Test Plan: Reviewers: Subscribers: Tasks: Tags: --- .github/workflows/regression_test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regression_test.yml b/.github/workflows/regression_test.yml index 191fb6fe6d..c478d1ef49 100644 --- a/.github/workflows/regression_test.yml +++ b/.github/workflows/regression_test.yml @@ -23,7 +23,7 @@ jobs: include: - name: CUDA 2.2.2 runs-on: linux.g5.12xlarge.nvidia.gpu - torch-spec: 'torch==2.2.2' + torch-spec: 'torch==2.2.2 numpy<2' gpu-arch-type: "cuda" gpu-arch-version: "12.1" - name: CUDA 2.3 From 356d1a411ef71025c02d7d7e9e03eca369713606 Mon Sep 17 00:00:00 2001 From: Jesse Cai Date: Wed, 24 Jul 2024 10:55:20 -0700 Subject: [PATCH 2/3] use == and specify for CPU as well --- .github/workflows/regression_test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/regression_test.yml b/.github/workflows/regression_test.yml index c478d1ef49..1698fb424f 100644 --- a/.github/workflows/regression_test.yml +++ b/.github/workflows/regression_test.yml @@ -23,7 +23,7 @@ jobs: include: - name: CUDA 2.2.2 runs-on: linux.g5.12xlarge.nvidia.gpu - torch-spec: 'torch==2.2.2 numpy<2' + torch-spec: 'torch==2.2.2 numpy==1.26' gpu-arch-type: "cuda" gpu-arch-version: "12.1" - name: CUDA 2.3 @@ -38,7 +38,7 @@ jobs: gpu-arch-version: "12.1" - name: CPU 2.2.2 runs-on: linux.4xlarge - torch-spec: 'torch==2.2.2 --index-url https://download.pytorch.org/whl/cpu' + torch-spec: 'torch==2.2.2 --index-url https://download.pytorch.org/whl/cpu numpy==1.26' gpu-arch-type: "cpu" gpu-arch-version: "" - name: CPU 2.3 From de6b95c62578ff894a06ab9f9c5d070dbf7ab064 Mon Sep 17 00:00:00 2001 From: Jesse Cai Date: Wed, 24 Jul 2024 11:00:01 -0700 Subject: [PATCH 3/3] update --- .github/workflows/regression_test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/regression_test.yml b/.github/workflows/regression_test.yml index 1698fb424f..119d228085 100644 --- a/.github/workflows/regression_test.yml +++ b/.github/workflows/regression_test.yml @@ -23,7 +23,7 @@ jobs: include: - name: CUDA 2.2.2 runs-on: linux.g5.12xlarge.nvidia.gpu - torch-spec: 'torch==2.2.2 numpy==1.26' + torch-spec: 'torch==2.2.2 "numpy<2" ' gpu-arch-type: "cuda" gpu-arch-version: "12.1" - name: CUDA 2.3 @@ -38,7 +38,7 @@ jobs: gpu-arch-version: "12.1" - name: CPU 2.2.2 runs-on: linux.4xlarge - torch-spec: 'torch==2.2.2 --index-url https://download.pytorch.org/whl/cpu numpy==1.26' + torch-spec: 'torch==2.2.2 --index-url https://download.pytorch.org/whl/cpu "numpy<2" ' gpu-arch-type: "cpu" gpu-arch-version: "" - name: CPU 2.3