test

Author: jathu

install_executorch.py

@@ -205,10 +205,8 @@ def main(args):
     cmake_args = [os.getenv("CMAKE_ARGS", "")]
     use_pytorch_nightly = True
 
-    has_pybindings = False
     wants_pybindings_off, pybind_defines = _list_pybind_defines(args)
     if not wants_pybindings_off:
-        has_pybindings = True
         if len(pybind_defines) > 0:
             # If the user explicitly provides a list of bindings, just use them
             cmake_args += pybind_defines
@@ -217,9 +215,6 @@ def main(args):
             # a list, then turn on xnnpack by default
             cmake_args.append("-DEXECUTORCH_BUILD_XNNPACK=ON")
 
-    if has_pybindings:
-        cmake_args.append("-DEXECUTORCH_BUILD_PYBIND=ON")
-
     if args.clean:
         clean()
         return

setup.py

@@ -107,7 +107,31 @@ def _is_cmake_arg_enabled(var: str, default: bool) -> bool:
 
     @classmethod
     def pybindings(cls) -> bool:
-        return cls._is_cmake_arg_enabled("EXECUTORCH_BUILD_PYBIND", default=False)
+        user_defined = _cmake_args_defines().get("EXECUTORCH_BUILD_PYBIND", None)
+        if user_defined is not None:
+            return cls._is_truthy(user_defined)
+        # If the user hasn't specified anything, we want to turn this on if any
+        # bindings are requested explicitly.
+        return any(
+            [
+                cls.coreml(),
+                cls.mps(),
+                cls.xnnpack(),
+                cls.training(),
+            ]
+        )
+
+    @classmethod
+    def coreml(cls) -> bool:
+        return cls._is_cmake_arg_enabled("EXECUTORCH_BUILD_COREML", default=False)
+
+    @classmethod
+    def mps(cls) -> bool:
+        return cls._is_cmake_arg_enabled("EXECUTORCH_BUILD_MPS", default=False)
+
+    @classmethod
+    def xnnpack(cls) -> bool:
+        return cls._is_cmake_arg_enabled("EXECUTORCH_BUILD_XNNPACK", default=False)
 
     @classmethod
     def training(cls) -> bool: