Skip to content

Commit 6116db2

Browse files
larryliu0820kirklandsign
authored andcommitted
[NOT-CLEAN-CP] Fix 3 CI jobs (#3006)
Summary: * [NOT APPLICABLE IN RELEASE] Apple / build-frameworks-ios / macos-job We removed libcustom_ops_lib.a in #2916 so need to remove it from `build_apple_frameworks.sh`. * [NOT APPLICABLE IN RELEASE] Lint / lintrunner / linux-job Remove extra line in backends/qualcomm/quantizer/utils.py * pull / unittest / macos (buck2) / macos-job Fix it by using `executorch_no_prim_ops` instead of `executorch` in MPS and CoreML. Pull Request resolved: #3006 Reviewed By: lucylq Differential Revision: D56048430 Pulled By: larryliu0820 fbshipit-source-id: 9dcb476eea446ea3aba566d595167c691fb00eec (cherry picked from commit 5b7c4ba)
1 parent 389393f commit 6116db2

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

backends/apple/coreml/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ target_include_directories(
144144
)
145145
target_link_libraries(
146146
coremldelegate PRIVATE
147-
executorch
147+
executorch_no_prim_ops
148148
)
149149

150150
if(EXECUTORCH_BUILD_SDK)
@@ -174,7 +174,7 @@ find_library(SQLITE_LIBRARY sqlite3)
174174

175175
target_link_libraries(coremldelegate
176176
PRIVATE
177-
executorch
177+
executorch_no_prim_ops
178178
${ACCELERATE_FRAMEWORK}
179179
${COREML_FRAMEWORK}
180180
${FOUNDATION_FRAMEWORK}
@@ -185,7 +185,7 @@ target_compile_options(coremldelegate PRIVATE "-fobjc-arc")
185185
target_compile_options(coremldelegate PRIVATE "-fno-exceptions")
186186

187187
if(EXECUTORCH_BUILD_SDK)
188-
target_compile_options(executorch PUBLIC -DET_EVENT_TRACER_ENABLED)
188+
target_compile_options(executorch_no_prim_ops PUBLIC -DET_EVENT_TRACER_ENABLED)
189189
target_compile_options(coremldelegate PRIVATE "-frtti")
190190
target_compile_options(libprotobuf-lite PRIVATE "-frtti")
191191
else()

backends/apple/mps/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ target_link_libraries(mpsdelegate
7070
PRIVATE
7171
bundled_program
7272
mps_schema
73-
${_executor_runner_libs}
73+
executorch_no_prim_ops
7474
${FOUNDATION_FRAMEWORK}
7575
${METAL_FRAMEWORK}
7676
${MPS_FRAMEWORK}

0 commit comments

Comments
 (0)