Skip to content

Commit d77ac15

Browse files
committed
[size_test] Allow passing in extra arguments
1 parent 12f4431 commit d77ac15

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

test/build_size_test.sh

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,26 +11,33 @@ set -e
1111
# shellcheck source=/dev/null
1212
source "$(dirname "${BASH_SOURCE[0]}")/../.ci/scripts/utils.sh"
1313

14+
EXTRA_BUILD_ARGS="${@:-}"
1415
# TODO(#8357): Remove -Wno-int-in-bool-context
1516
COMMON_CXXFLAGS="-fno-exceptions -fno-rtti -Wall -Werror -Wno-int-in-bool-context"
1617

1718
cmake_install_executorch_lib() {
1819
echo "Installing libexecutorch.a"
1920
clean_executorch_install_folders
2021
update_tokenizers_git_submodule
22+
local EXTRA_BUILD_ARGS="${@}"
23+
2124
CXXFLAGS="$COMMON_CXXFLAGS" retry cmake -DBUCK2="$BUCK2" \
2225
-DCMAKE_CXX_STANDARD_REQUIRED=ON \
2326
-DCMAKE_INSTALL_PREFIX=cmake-out \
2427
-DCMAKE_BUILD_TYPE=Release \
2528
-DEXECUTORCH_BUILD_EXECUTOR_RUNNER=OFF \
2629
-DOPTIMIZE_SIZE=ON \
2730
-DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \
31+
${EXTRA_BUILD_ARGS} \
2832
-Bcmake-out .
2933
cmake --build cmake-out -j9 --target install --config Release
3034
}
3135

3236
test_cmake_size_test() {
33-
CXXFLAGS="$COMMON_CXXFLAGS" retry cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=cmake-out -Bcmake-out/test test
37+
CXXFLAGS="$COMMON_CXXFLAGS" retry cmake -DCMAKE_BUILD_TYPE=Release \
38+
-DCMAKE_INSTALL_PREFIX=cmake-out \
39+
${EXTRA_BUILD_ARGS} \
40+
-Bcmake-out/test test
3441

3542
echo "Build size test"
3643
cmake --build cmake-out/test -j9 --config Release
@@ -46,5 +53,5 @@ if [[ -z $PYTHON_EXECUTABLE ]]; then
4653
PYTHON_EXECUTABLE=python3
4754
fi
4855

49-
cmake_install_executorch_lib
50-
test_cmake_size_test
56+
cmake_install_executorch_lib ${EXTRA_BUILD_ARGS}
57+
test_cmake_size_test ${EXTRA_BUILD_ARGS}

0 commit comments

Comments
 (0)