Skip to content

Refactor ArmBackend::preprocess() #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
digantdesai opened this issue Oct 6, 2023 · 3 comments
Closed

Refactor ArmBackend::preprocess() #667

digantdesai opened this issue Oct 6, 2023 · 3 comments
Assignees
@Jerry-Ge
Labels
enhancement Not as big of a feature, but technically not a bug. Should be easy to fix partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@digantdesai
Copy link
Contributor 

          this is not scalable, and we are getting quite close to **spaghettification** point, I think #1 priority after MVP should be to refactor `preprocess()`.

Originally posted by @digantdesai in #616 (comment)
@digantdesai
Copy link
Contributor Author

cc @cccclai

@digantdesai digantdesai mentioned this issue Oct 6, 2023
Closed
@dbort dbort added enhancement Not as big of a feature, but technically not a bug. Should be easy to fix partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Oct 23, 2023
@Jerry-Ge
Copy link
Contributor

Jerry-Ge commented Oct 26, 2023 •
edited
Loading

Fix here: #1099

@Jerry-Ge
Copy link
Contributor

Jerry-Ge commented Nov 9, 2023

The patch already got merged, I think we can close this issue now. @digantdesai @dbort

@cccclai cccclai closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jerry-Ge Jerry-Ge

Labels
enhancement Not as big of a feature, but technically not a bug. Should be easy to fix partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@digantdesai @dbort @cccclai @Jerry-Ge