Skip to content

Benchmark: Report memory usage in Android benchmark app #7988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
guangy10 opened this issue Jan 28, 2025 · 2 comments
Closed

Benchmark: Report memory usage in Android benchmark app #7988

guangy10 opened this issue Jan 28, 2025 · 2 comments
Assignees
@kirklandsign
Labels
module: android Issues related to Android code, build, and execution module: benchmark Issues related to the benchmark infrastructure triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone
0.7.0

Comments

@guangy10
Copy link
Contributor

guangy10 commented Jan 28, 2025 •
edited
Loading

🚀 The feature, motivation and pitch

Reporting peak memory usage at loading/inference time has been supported by the iOS benchmark app, we should add same support to Android benchmark app.

Image

Alternatives

No response

Additional context

No response

RFC (Optional)

No response

cc @kirklandsign @digantdesai @kimishpatel
@guangy10 guangy10 added module: android Issues related to Android code, build, and execution feature module: benchmark Issues related to the benchmark infrastructure labels Jan 28, 2025
@manuelcandales manuelcandales added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 28, 2025
@guangy10 guangy10 moved this to Todo in ExecuTorch Benchmark Feb 6, 2025
@guangy10
Copy link
Contributor Author

guangy10 commented Feb 6, 2025

@kirklandsign This work is carried over from last half. We should prioritize this to be on-par with the iOS setup. I think you may be able to leverage the work in #8241 for this task. Can you do the due diligence if we could consolidate them into one effort?

@guangy10 guangy10 added this to the 0.6.0 milestone Feb 10, 2025
@jackzhxng jackzhxng removed the feature label Feb 21, 2025
@kirklandsign kirklandsign modified the milestones: 0.6.0, 0.7.0 Apr 10, 2025
@kirklandsign
Copy link
Contributor

Fixed by #8984

@github-project-automation github-project-automation bot moved this from Ready to Done in ExecuTorch Benchmark Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirklandsign kirklandsign

Labels
module: android Issues related to Android code, build, and execution module: benchmark Issues related to the benchmark infrastructure triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
ExecuTorch Android
Archived in project
ExecuTorch Benchmark
Status: Done
Milestone
0.7.0
Development

No branches or pull requests
4 participants
@jackzhxng @manuelcandales @guangy10 @kirklandsign