-
Notifications
You must be signed in to change notification settings - Fork 537
Warn or error when using unsupported Python version #8156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi there, I'm not sure, but if the Python version is unsupported, it may be better to exit with an error in Or, if you think that it is better to error when importing, it can be in I’d be happy to help with this issue if that’s okay |
@ahbpp - feel free to put up a PR, thank you cc @dbort , @larryliu0820 , @jathu |
Thanks for taking a look at this. Doing it setup.py seems reasonable. |
Sorry, it is actually already implemented in
|
@ahbpp Ah, that must have been added semi-recently. Sorry about that. Thanks for finding this. I will close this issue. |
🚀 The feature, motivation and pitch
Lowering can fail in weird ways when using older, unsupported Python versions. We should warn or error out when importing the executorch Python package on an unsupported Python version.
See #2025 for an example of this.
Alternatives
No response
Additional context
No response
RFC (Optional)
No response
cc @larryliu0820 @lucylq @mergennachin @byjlw
The text was updated successfully, but these errors were encountered: