Skip to content

Inconsistent logo between GitHub repo and documentation site #8163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
guangy10 opened this issue Feb 4, 2025 · 6 comments
Open

Inconsistent logo between GitHub repo and documentation site #8163

guangy10 opened this issue Feb 4, 2025 · 6 comments
Assignees
@byjlw
Labels
enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: doc Issues related to documentation, both in docs/ and inlined in code module: user experience Issues related to reducing friction for users triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone
0.6.0

Comments

@guangy10
Copy link
Contributor

guangy10 commented Feb 4, 2025 •
edited by pytorch-bot bot
Loading

🐛 Describe the bug

Our documentation site (https://pytorch.org/executorch/main/index.html) is still referencing the old et logo.

Versions

trunk

cc @mergennachin @byjlw
@guangy10 guangy10 added module: doc Issues related to documentation, both in docs/ and inlined in code enhancement Not as big of a feature, but technically not a bug. Should be easy to fix labels Feb 4, 2025
@guangy10
Copy link
Contributor Author

guangy10 commented Feb 4, 2025

@byjlw assign to you since you were working on #8126 where the new logo was introduced

@guangy10 guangy10 moved this to To triage in ExecuTorch DevX Feb 4, 2025
@guangy10 guangy10 moved this from To triage to Ready in ExecuTorch DevX Feb 4, 2025
@guangy10 guangy10 mentioned this issue Feb 4, 2025
Merged
@digantdesai digantdesai added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 4, 2025
@mergennachin mergennachin added the module: user experience Issues related to reducing friction for users label Feb 4, 2025
@mergennachin mergennachin added this to the 0.6.0 milestone Feb 6, 2025
@byjlw
Copy link
Contributor

byjlw commented Feb 7, 2025

Image

You're talking about this one?

@guangy10
Copy link
Contributor Author

guangy10 commented Feb 8, 2025

Yes

@github-actions github-actions bot mentioned this issue Feb 11, 2025
Open
@dbort
Copy link
Contributor

dbort commented Feb 13, 2025

I just published the logo (PNG + SVG) to https://github.com/dbort/executorch-logos/blob/main/img/executorch-chip-logo-white.png under a BSD license compatible with ExecuTorch's

There's also a version with a transparent background in the same directory; that'll probably be better for the site.

I see that the website uses the old logo for its favicon, too. I don't know if this logo will look good that small: I can experiment with a smaller version

@dbort
Copy link
Contributor

dbort commented Feb 13, 2025

Added 32x32 and 16x16 versions to use as favicons:

@github-actions github-actions bot mentioned this issue Feb 17, 2025
Open
This was referenced Feb 24, 2025
Open
Open
@mergennachin
Copy link
Contributor

Was this done for 0.6 by any chance @byjlw ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@byjlw byjlw

Labels
enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: doc Issues related to documentation, both in docs/ and inlined in code module: user experience Issues related to reducing friction for users triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
ExecuTorch DevX
Status: Ready
Milestone
0.6.0
Development

No branches or pull requests
5 participants
@digantdesai @mergennachin @dbort @byjlw @guangy10