Skip to content

Distribute Android binaries through a Maven repository #8259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GregoryComer opened this issue Feb 6, 2025 · 6 comments
Closed

Distribute Android binaries through a Maven repository #8259

GregoryComer opened this issue Feb 6, 2025 · 6 comments
Assignees
Labels
module: android Issues related to Android code, build, and execution module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch module: user experience Issues related to reducing friction for users triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone

Comments

@GregoryComer
Copy link
Member

GregoryComer commented Feb 6, 2025

🚀 The feature, motivation and pitch

We currently build Android AARs and make them accessible for direct download from S3. We can build on top of this by uploading and distributing the binaries through a Maven repository. This will allow users to simply add the dependency to their Maven or Gradle build and automatically pull the appropriate binary without needing to manually download and manage the artifact.

I don't personally have a ton of context on the Java / Android package management ecosystem, so I'll defer to experts (CC @kirklandsign), but it seems like Maven Central Repository is the way to go. We may be able to leverage work previously done by the PyTorch Dev Infra team to do this.

We will upload to maven and have a page like this. We would need to upload AAR and a POM file

Alternatives

No response

Additional context

No response

RFC (Optional)

No response

cc @larryliu0820 @lucylq @kirklandsign @cbilgin @mergennachin @byjlw

@GregoryComer GregoryComer added module: android Issues related to Android code, build, and execution module: user experience Issues related to reducing friction for users labels Feb 6, 2025
@github-project-automation github-project-automation bot moved this to To triage in ExecuTorch DevX Feb 6, 2025
@GregoryComer GregoryComer moved this from To triage to Ready in ExecuTorch DevX Feb 6, 2025
@mergennachin mergennachin added this to the 0.6.0 milestone Feb 6, 2025
@digantdesai
Copy link
Contributor

Should this be a discussion?

@digantdesai digantdesai added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 6, 2025
@GregoryComer
Copy link
Member Author

GregoryComer commented Feb 6, 2025

Should this be a discussion?

I think we want to do this and have alignment, so it should be ready to pick up. There's a lot of interest in getting away from source builds for mobile use cases and Hansong has already done the work to generate the pre-builts, we just need to register and upload them.

Edit: So I think it can be left as an issue. It's actionable.

@jathu
Copy link
Contributor

jathu commented Mar 4, 2025

@kirklandsign should we include 0.5 initially and setup CI to push 0.6 when released? or should we just make 0.6 as the initial release?

cc @larryliu0820 @mergennachin

@kirklandsign
Copy link
Contributor

0.6 should be the initial release.

I would love to have some snapshot from main to test it out before 0.6 though.

@byjlw
Copy link
Contributor

byjlw commented Mar 5, 2025

Should this be a discussion?

I think we want to do this and have alignment, so it should be ready to pick up. There's a lot of interest in getting away from source builds for mobile use cases and Hansong has already done the work to generate the pre-builts, we just need to register and upload them.

Edit: So I think it can be left as an issue. It's actionable.

@kirklandsign can we update the description of this issue to include what success looks like since it's a scheduled item?

@kirklandsign kirklandsign moved this from Ready to Done in ExecuTorch DevX Mar 27, 2025
@kirklandsign kirklandsign closed this as completed by moving to Done in ExecuTorch DevX Mar 27, 2025
@kirklandsign
Copy link
Contributor

Should this be a discussion?

I think we want to do this and have alignment, so it should be ready to pick up. There's a lot of interest in getting away from source builds for mobile use cases and Hansong has already done the work to generate the pre-builts, we just need to register and upload them.
Edit: So I think it can be left as an issue. It's actionable.

@kirklandsign can we update the description of this issue to include what success looks like since it's a scheduled item?

Updated. Artifact in https://mvnrepository.com/artifact/org.pytorch/executorch-android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: android Issues related to Android code, build, and execution module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch module: user experience Issues related to reducing friction for users triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
Status: Done
Development

No branches or pull requests

7 participants