Skip to content

Expose runtime error codes / results in JNI #8260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GregoryComer opened this issue Feb 6, 2025 · 1 comment
Open

Expose runtime error codes / results in JNI #8260

GregoryComer opened this issue Feb 6, 2025 · 1 comment
Assignees
Labels
module: android Issues related to Android code, build, and execution module: user experience Issues related to reducing friction for users triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone

Comments

@GregoryComer
Copy link
Member

GregoryComer commented Feb 6, 2025

🚀 The feature, motivation and pitch

Currently, the Android JNI bindings do not expose error codes or results through the API. Failure is indicated with empty EValues. It would be desirable to either implement a Result type (similar to the native API), or use Java exceptions to communicate failure. Ultimately, the goal is to clearly provide error codes / information on inference or model load failures. This will be a big improvement for debuggability, as logging is not always easily available (for example, in production).

Alternatives

No response

Additional context

No response

RFC (Optional)

No response

cc @kirklandsign @mergennachin @byjlw

@GregoryComer GregoryComer added module: android Issues related to Android code, build, and execution module: user experience Issues related to reducing friction for users labels Feb 6, 2025
@github-project-automation github-project-automation bot moved this to To triage in ExecuTorch DevX Feb 6, 2025
@GregoryComer GregoryComer moved this from To triage to Ready in ExecuTorch DevX Feb 6, 2025
@mergennachin mergennachin added this to the 0.6.0 milestone Feb 6, 2025
@digantdesai digantdesai added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 6, 2025
@kirklandsign kirklandsign modified the milestones: 0.6.0, 0.7.0 Mar 27, 2025
@kirklandsign
Copy link
Contributor

Need to move to 0.7.0.

@kirklandsign kirklandsign moved this from Ready to Incoming in ExecuTorch DevX Mar 29, 2025
@kirklandsign kirklandsign moved this from Incoming to Ready in ExecuTorch DevX Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: android Issues related to Android code, build, and execution module: user experience Issues related to reducing friction for users triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
Status: Ready
Development

No branches or pull requests

4 participants