Skip to content

Move examples + tests to single-step CMake build #8274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GregoryComer opened this issue Feb 6, 2025 · 0 comments
Open

Move examples + tests to single-step CMake build #8274

GregoryComer opened this issue Feb 6, 2025 · 0 comments
Labels
module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch module: user experience Issues related to reducing friction for users triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone

Comments

@GregoryComer
Copy link
Member

GregoryComer commented Feb 6, 2025

🚀 The feature, motivation and pitch

Currently, many examples and tests are built using a two-step process, where the executorch core is built and then "installed" into the build directory used by the example or test. This ends up being quite fragile as iterative rebuilds often don't work nicely and it's very easy for it not work when the initial build isn't configured exactly right for the test or example. It should be significantly more robust and "just work" if we either migrate all of these targets to include executorch via add_subdirectory (it should be possible to include the parent directory, so long as there is no cycle. Might need to play around with relative vs absolute paths). The other option is to include them from the main build/CMakeLists under the main CMakeLists. It may make sense to do this for tests and keep examples using add_subdirectory, but could be discussed more.

Alternatives

No response

Additional context

No response

RFC (Optional)

No response

cc @larryliu0820 @mergennachin @byjlw

@GregoryComer GregoryComer added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch module: user experience Issues related to reducing friction for users labels Feb 6, 2025
@github-project-automation github-project-automation bot moved this to To triage in ExecuTorch DevX Feb 6, 2025
@digantdesai digantdesai added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 6, 2025
@mergennachin mergennachin moved this from To triage to Backlog in ExecuTorch DevX Feb 6, 2025
@mergennachin mergennachin added this to the 0.6.0 milestone Feb 6, 2025
@mergennachin mergennachin moved this from Backlog to Ready in ExecuTorch DevX Feb 6, 2025
@mergennachin mergennachin moved this from Ready to Backlog in ExecuTorch DevX Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch module: user experience Issues related to reducing friction for users triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
Status: Backlog
Development

No branches or pull requests

3 participants