Skip to content

Remove EXECUTORCH_BUILD_HOST_TARGETS #9404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jathu opened this issue Mar 19, 2025 · 4 comments · Fixed by #10320
Closed

Remove EXECUTORCH_BUILD_HOST_TARGETS #9404

jathu opened this issue Mar 19, 2025 · 4 comments · Fixed by #10320
Labels
actionable Items in the backlog waiting for an appropriate impl/fix good first issue Good for newcomers module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch

Comments

@jathu
Copy link
Contributor

jathu commented Mar 19, 2025 •
edited by pytorch-bot bot
Loading

Given we now build flatc for the host (#9077, #9306), continue these steps to eventually remove EXECUTORCH_BUILD_HOST_TARGETS.

cc @larryliu0820 @lucylq
@jathu jathu added actionable Items in the backlog waiting for an appropriate impl/fix good first issue Good for newcomers module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch labels Mar 19, 2025
@jathu jathu mentioned this issue Mar 19, 2025
Merged
@kimishpatel
Copy link
Contributor

Who is looking into this?

@jathu
Copy link
Contributor Author

jathu commented Mar 24, 2025

Who is looking into this?

This isn't urgent, so we can eventually get to it. If no one picks it up, I will when I get a chance

@bvanderhaar
Copy link
Contributor

I'll take a shot at this, submitting a PR shortly.

@bvanderhaar bvanderhaar mentioned this issue Apr 21, 2025
Merged
@bvanderhaar
Copy link
Contributor

Submitted #10320. I ensured I could produce clean builds, otherwise it's largely cosmetic. Happy to more thoroughly test if needed.

@jathu jathu closed this as completed in 7783ade Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Items in the backlog waiting for an appropriate impl/fix good first issue Good for newcomers module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch
Projects
New Contributors Projects and Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor no longer needed EXECUTORCH_BUILD_HOST_TARGETS bvanderhaar/executorch
3 participants
@bvanderhaar @jathu @kimishpatel