Skip to content

Return "platform not supported" when using PyTorch on intel-based Macbooks #9772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nil-is-all opened this issue Mar 31, 2025 · 9 comments · May be fixed by #10652
Open

Return "platform not supported" when using PyTorch on intel-based Macbooks #9772

nil-is-all opened this issue Mar 31, 2025 · 9 comments · May be fixed by #10652
Labels
good first issue Good for newcomers module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@nil-is-all
Copy link

nil-is-all commented Mar 31, 2025

🚀 The feature, motivation and pitch

Currently, when a user installs requirements for ExecuTorch on their Intel-chip Macbook by running the ./install_requirements.sh after git-cloning the ExecuTorch repo, the installation fails for torch versions, throwing an error and a stack trace.

ERROR: Could not find a version that satisfies the requirement torch==2.7.0.dev20250310 (from versions: 1.11.0, 1.12.0, 1.12.1, 1.13.0, 1.13.1, 2.0.0, 2.0.1, 2.1.0, 2.1.1, 2.1.2, 2.2.0, 2.2.1, 2.2.2) ERROR: No matching distribution found for torch==2.7.0.dev20250310

Image

Alternatives

  1. Return a message stating "this platform is not supported" while running PyTorch on Intel Macbooks
  2. Updating documentation to add a disclaimer or in pre-requisites that PyTorch does not work anymore on Intel Macbooks.

Additional context

No response

RFC (Optional)

No response

cc @larryliu0820 @jathu @lucylq

@GregoryComer GregoryComer added good first issue Good for newcomers module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Mar 31, 2025
@swolchok
Copy link
Contributor

See #6691 (comment) . In short, PyTorch officially deprecated Intel Macs back in January 2024. ExecuTorch is PyTorch, so I imagine we will follow suit.

@ali-khosh
Copy link

Right. I don't think the goal is to add support. But instead to make documentation/errors more human readable, as suggested in the Alternative section above:

  • Return a message stating "this platform is not supported" while running PyTorch on Intel Macbooks
  • Updating documentation to add a disclaimer or in pre-requisites that PyTorch does not work anymore on Intel Macbooks.

@keyprocedure
Copy link
Contributor

I’d be down to work on this!

@mergennachin
Copy link
Contributor

@swolchok @keyprocedure @ali-khosh

ExecuTorch itself actually works with Intel Macs -- as in users should be able to install ExecuTorch from source. The reason it is "not working" is that torch package is not available on Intel Mac via pypi. However, we should be able to compile torch from source and install on Intel Mac first.

Instead of upright saying, "we don't support Intel Macs", what's your thought on adding a documentation on how-to do compile torch and ExecuTorch from source on Intel Macs.

@keyprocedure
Copy link
Contributor

I’d be happy to help with documentation for building from source if that’s the direction we move in.

@mergennachin
Copy link
Contributor

@keyprocedure

Yes, I agree with this direction for improving documentation and scripts for such use cases.
For reference, these past issues provide context:

#6691
#6689
#7732

And the current documentation: https://pytorch.org/executorch/0.6/using-executorch-building-from-source.html
Currently, ./install_executorch.sh script first downloads and installs the torch pip package. I'd like the documentation to include instructions similar to:

"If you want to compile torch version, here's what you can do:

For Intel Mac support, we should clarify: "We don't officially support prebuilt binaries for PyPI on Intel Macs, but here's how you can compile from source." This applies to any scenario where developers need to compile from source (e.g., needing the latest version).

Your task would be to:

  • Verify this workflow works in clean conda environments
  • Update the docs to reflect this process

@keyprocedure
Copy link
Contributor

keyprocedure commented Apr 23, 2025

@mergennachin Sounds good! I'll look into this and follow up soon.

@keyprocedure
Copy link
Contributor

keyprocedure commented Apr 29, 2025

@mergennachin

After building PyTorch from source on an Intel-Mac and adding a --no-deps flag to the pip install command, I'm getting some build errors when I run ./install_executorch.sh --use-pt-pinned-commit. Since torch is downgraded to torch-2.2.2-cp310-none-macosx_10_9_x86_64.whl, it looks like some components are missing and I'm getting the following errors:

  • error: use of undeclared identifier 'C10_FALLTHROUGH
  • ATen/native/cpu/Gelu.h not found
  • no matching conversion for static_cast from 'c10::complex<c10::Half>' to 'c10::complex<double>'
  • use of undeclared identifier 'overflows'

Do you have any suggestions on how to move forward?

@keyprocedure
Copy link
Contributor

keyprocedure commented May 2, 2025

I was able to prevent pip from changing the installed PyTorch build when running install_executorch.sh --use-pt-pinned-commit by adding the no-deps flag to the pip install command in install_requirements.sh. After debugging some issues (TorchConfig.cmake not found, missing omp.h, and a libomp.dylib link error), I was able to install executorch with a prebuilt PyTorch build on both an Intel and ARM64 macOS system.

I opened a draft PR. If it looks good, I'd be happy to publish it.

What do you all think about next steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
6 participants