From d54e9cac7ccaa417085d77a3fb9c9da6a186f7a6 Mon Sep 17 00:00:00 2001 From: Hansong Zhang Date: Wed, 5 Mar 2025 16:24:11 -0800 Subject: [PATCH 1/2] [minibench] Add RSS stats --- extension/benchmark/android/benchmark/app/build.gradle.kts | 6 +++--- .../main/java/org/pytorch/minibench/BenchmarkActivity.java | 5 +++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/extension/benchmark/android/benchmark/app/build.gradle.kts b/extension/benchmark/android/benchmark/app/build.gradle.kts index dcf99ca9cd0..6f35d9a34f6 100644 --- a/extension/benchmark/android/benchmark/app/build.gradle.kts +++ b/extension/benchmark/android/benchmark/app/build.gradle.kts @@ -10,12 +10,12 @@ plugins { id("com.android.application") } android { namespace = "org.pytorch.minibench" - compileSdk = 34 + compileSdk = 35 defaultConfig { applicationId = "org.pytorch.minibench" - minSdk = 28 - targetSdk = 33 + minSdk = 35 + targetSdk = 35 versionCode = 1 versionName = "1.0" diff --git a/extension/benchmark/android/benchmark/app/src/main/java/org/pytorch/minibench/BenchmarkActivity.java b/extension/benchmark/android/benchmark/app/src/main/java/org/pytorch/minibench/BenchmarkActivity.java index 4b2ba56099e..664e73b0fd3 100644 --- a/extension/benchmark/android/benchmark/app/src/main/java/org/pytorch/minibench/BenchmarkActivity.java +++ b/extension/benchmark/android/benchmark/app/src/main/java/org/pytorch/minibench/BenchmarkActivity.java @@ -12,6 +12,7 @@ import android.content.Intent; import android.os.AsyncTask; import android.os.Bundle; +import android.os.Debug; import android.system.ErrnoException; import android.system.Os; import com.google.gson.Gson; @@ -59,6 +60,8 @@ protected Void doInBackground(Void... voids) { Module module = Module.load(model.getPath()); stats.errorCode = module.loadMethod("forward"); stats.loadEnd = System.nanoTime(); + // RAM RSS usage + results.add(new BenchmarkMetric(benchmarkModel, "peak_load_mem_usage(mb)", Debug.getRss(), 0)); for (int i = 0; i < numWarmupIter; i++) { module.forward(); @@ -103,6 +106,8 @@ protected void onPostExecute(Void aVoid) { 0.0f)); // Load status results.add(new BenchmarkMetric(benchmarkModel, "load_status", stats.errorCode, 0)); + // RAM RSS usage + results.add(new BenchmarkMetric(benchmarkModel, "peak_inference_mem_usage(mb)", Debug.getRss(), 0)); try (FileWriter writer = new FileWriter(getFilesDir() + "/benchmark_results.json")) { Gson gson = new Gson(); From 7ac8de05ba1ee83a6a8bd35b6546697ca4d11cdb Mon Sep 17 00:00:00 2001 From: Hansong Zhang Date: Wed, 5 Mar 2025 16:28:26 -0800 Subject: [PATCH 2/2] Fix --- .../src/main/java/org/pytorch/minibench/BenchmarkActivity.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/extension/benchmark/android/benchmark/app/src/main/java/org/pytorch/minibench/BenchmarkActivity.java b/extension/benchmark/android/benchmark/app/src/main/java/org/pytorch/minibench/BenchmarkActivity.java index 664e73b0fd3..647e49b6cf8 100644 --- a/extension/benchmark/android/benchmark/app/src/main/java/org/pytorch/minibench/BenchmarkActivity.java +++ b/extension/benchmark/android/benchmark/app/src/main/java/org/pytorch/minibench/BenchmarkActivity.java @@ -60,8 +60,6 @@ protected Void doInBackground(Void... voids) { Module module = Module.load(model.getPath()); stats.errorCode = module.loadMethod("forward"); stats.loadEnd = System.nanoTime(); - // RAM RSS usage - results.add(new BenchmarkMetric(benchmarkModel, "peak_load_mem_usage(mb)", Debug.getRss(), 0)); for (int i = 0; i < numWarmupIter; i++) { module.forward();