From 162a0b9b824167a4d91d1dc20bbd4677af7a25a3 Mon Sep 17 00:00:00 2001 From: Harish Srinivas Date: Fri, 7 Mar 2025 12:37:46 -0800 Subject: [PATCH] Remove explicit descriptor where not needed (#9046) Summary: we only need this for constructors with one param Reviewed By: JacobSzwejbka Differential Revision: D70793102 --- extension/training/optimizer/sgd.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/extension/training/optimizer/sgd.h b/extension/training/optimizer/sgd.h index 055d561287d..9e3ab42817a 100644 --- a/extension/training/optimizer/sgd.h +++ b/extension/training/optimizer/sgd.h @@ -179,17 +179,14 @@ class ET_EXPERIMENTAL SGDParamGroup { */ class ET_EXPERIMENTAL SGD { public: - explicit SGD( - const std::vector& param_groups, - SGDOptions defaults) + SGD(const std::vector& param_groups, SGDOptions defaults) : defaults_(std::make_unique(defaults)) { for (const auto& param_group : param_groups) { add_param_group(param_group); } } - explicit SGD( - const std::map& + SGD(const std::map& named_parameters, SGDOptions defaults) : SGD({SGDParamGroup(named_parameters)}, defaults) {}