diff --git a/.ci/scripts/unittest-buck2.sh b/.ci/scripts/unittest-buck2.sh index 59b8ac6ccd2..efbf386ffa0 100755 --- a/.ci/scripts/unittest-buck2.sh +++ b/.ci/scripts/unittest-buck2.sh @@ -8,9 +8,7 @@ set -eux # TODO: expand this to //... # TODO: can't query cadence & vulkan backends -# TODO: can't query //kernels/prim_ops because of a cpp_unittest and -# broken code in shim to read oss.folly_cxx_tests. Sending fix but it -# needs to propagate and we need a submodule update. +# TODO: can't query //kernels/prim_ops because of non-buckified stuff in OSS. buck2 query "//backends/apple/... + //backends/example/... + \ //backends/mediatek/... + //backends/test/... + //backends/transforms/... + \ //backends/xnnpack/... + //configurations/... + //kernels/aten/... + \ @@ -20,7 +18,9 @@ buck2 query "//backends/apple/... + //backends/example/... + \ UNBUILDABLE_OPTIMIZED_OPS_REGEX="gelu|fft_r2c|log_softmax" BUILDABLE_OPTIMIZED_OPS=$(buck2 query //kernels/optimized/cpu/... | grep -E -v $UNBUILDABLE_OPTIMIZED_OPS_REGEX) -BUILDABLE_KERNELS_PRIM_OPS_TARGETS=$(buck2 query //kernels/prim_ops/... | grep -v prim_ops_test_py) +# TODO: build prim_ops_test_cpp again once supported_features works in +# OSS buck. +BUILDABLE_KERNELS_PRIM_OPS_TARGETS=$(buck2 query //kernels/prim_ops/... | grep -v prim_ops_test) # TODO: expand the covered scope of Buck targets. # //runtime/kernel/... is failing because //third-party:torchgen_files's shell script can't find python on PATH. # //runtime/test/... requires Python torch, which we don't have in our OSS buck setup. diff --git a/.github/workflows/pull.yml b/.github/workflows/pull.yml index 75d1db2cd36..42e65eb3253 100644 --- a/.github/workflows/pull.yml +++ b/.github/workflows/pull.yml @@ -361,6 +361,7 @@ jobs: CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]") conda activate "${CONDA_ENV}" + ./install_requirements.sh --use-pt-pinned-commit # build module for executorch.extension.pybindings.portable_lib bash test/build_size_test.sh strip cmake-out/test/size_test @@ -396,6 +397,8 @@ jobs: CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]") conda activate "${CONDA_ENV}" + ./install_requirements.sh --use-pt-pinned-commit + # build module for executorch.extension.pybindings.portable_lib bash test/build_size_test.sh strip cmake-out/test/size_test @@ -510,6 +513,7 @@ jobs: MODE=${{ matrix.mode }} PT2E_QUANTIZE=${{ matrix.pt2e_quantize }} + ./install_requirements.sh --use-pt-pinned-commit PYTHON_EXECUTABLE=python bash .ci/scripts/setup-qnn-deps.sh PYTHON_EXECUTABLE=python bash .ci/scripts/build-qnn-sdk.sh @@ -541,6 +545,7 @@ jobs: BUILD_TOOL="cmake" + ./install_requirements.sh --use-pt-pinned-commit PYTHON_EXECUTABLE=python bash .ci/scripts/setup-qnn-deps.sh PYTHON_EXECUTABLE=python bash .ci/scripts/build-qnn-sdk.sh diff --git a/.github/workflows/trunk.yml b/.github/workflows/trunk.yml index e907e8215c9..4296633940f 100644 --- a/.github/workflows/trunk.yml +++ b/.github/workflows/trunk.yml @@ -572,6 +572,7 @@ jobs: MODE=${{ matrix.mode }} PT2E_QUANTIZE=${{ matrix.pt2e_quantize }} + ./install_requirements.sh --use-pt-pinned-commit PYTHON_EXECUTABLE=python bash .ci/scripts/setup-qnn-deps.sh PYTHON_EXECUTABLE=python bash .ci/scripts/build-qnn-sdk.sh diff --git a/CMakeLists.txt b/CMakeLists.txt index dfbc3425fed..4d901fcb27c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -42,7 +42,7 @@ # It should also be cmake-lint clean. # -cmake_minimum_required(VERSION 3.19) +cmake_minimum_required(VERSION 3.24) project(executorch) include(build/Utils.cmake) include(CMakeDependentOption) @@ -919,6 +919,14 @@ if(EXECUTORCH_BUILD_EXECUTOR_RUNNER) list(APPEND _executor_runner_libs quantized_ops_lib) endif() + if(EXECUTORCH_BUILD_KERNELS_CUSTOM) + list(APPEND _executor_runner_libs $) + endif() + + if(EXECUTORCH_BUILD_XNNPACK) + list(APPEND _executor_runner_libs xnnpack_backend) + endif() + if(EXECUTORCH_ENABLE_EVENT_TRACER) if(EXECUTORCH_BUILD_DEVTOOLS) list(APPEND _executor_runner_libs etdump flatccrt) diff --git a/backends/xnnpack/CMakeLists.txt b/backends/xnnpack/CMakeLists.txt index 09fc79a4946..febd112a148 100644 --- a/backends/xnnpack/CMakeLists.txt +++ b/backends/xnnpack/CMakeLists.txt @@ -118,7 +118,7 @@ include(cmake/Dependencies.cmake) list(TRANSFORM _xnnpack_backend__srcs PREPEND "${EXECUTORCH_ROOT}/") add_library(xnnpack_backend STATIC ${_xnnpack_backend__srcs}) target_link_libraries( - xnnpack_backend PUBLIC ${xnnpack_third_party} executorch_core xnnpack_schema + xnnpack_backend PUBLIC ${xnnpack_third_party} executorch_core xnnpack_schema extension_threadpool ) target_include_directories( diff --git a/kernels/test/targets.bzl b/kernels/test/targets.bzl index 7afc9aa1a59..18ab0ac2e28 100644 --- a/kernels/test/targets.bzl +++ b/kernels/test/targets.bzl @@ -37,7 +37,7 @@ def define_common_targets(): ], fbcode_exported_deps = [ "//common/gtest:gtest", - ], + ] if not runtime.is_oss else [], xplat_exported_deps = [ "//third-party/googletest:gtest_main", ], @@ -68,7 +68,7 @@ def define_common_targets(): fbcode_exported_deps = [ "//common/init:init", "//common/gtest:gtest", - ], + ] if not runtime.is_oss else [], xplat_exported_deps = [ "//xplat/folly:init_init", "//third-party/googletest:gtest_main",