Fix -Wnontrivial-memcall error in AllreduceLocal

luciang · web-flow · commit 980c9257671b · 2026-01-13T20:15:57.000Z
Differential Revision: D90555676 Pull Request resolved: #482
diff --git a/gloo/allreduce_local.cc b/gloo/allreduce_local.cc
@@ -32,7 +32,7 @@ void AllreduceLocal<T>::run() {
   }
   // Broadcast ptrs_[0]
   for (int i = 1; i < ptrs_.size(); i++) {
-    memcpy(ptrs_[i], ptrs_[0], bytes_);
+    memcpy((void*)ptrs_[i], (const void*)ptrs_[0], bytes_);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ void AllreduceLocal<T>::run() {`
`32`	`32`	`}`
`33`	`33`	`// Broadcast ptrs_[0]`
`34`	`34`	`for (int i = 1; i < ptrs_.size(); i++) {`
`35`		`- memcpy(ptrs_[i], ptrs_[0], bytes_);`
	`35`	`+ memcpy((void)ptrs_[i], (const void)ptrs_[0], bytes_);`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`