Update Dr.CI to use the list of unstable issues #5131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
clee2000
approved these changes
Apr 25, 2024
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 26, 2024
…24965) After pytorch/test-infra#5131, we want to have trymerge to honor the list of unstable failures from Dr.CI because having the unstable keyword is the job name now doesn't cover all unstable jobs. Pull Request resolved: #124965 Approved by: https://github.com/clee2000
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
May 3, 2024
…torch#124965) After pytorch/test-infra#5131, we want to have trymerge to honor the list of unstable failures from Dr.CI because having the unstable keyword is the job name now doesn't cover all unstable jobs. Pull Request resolved: pytorch#124965 Approved by: https://github.com/clee2000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next part of #5122 where Dr.CI also uses the list of unstable issues to check if a job is an unstable job. The same function
isUnstableJobthat powers HUD from #5122 is used.Testing
Mark a job on ET as unstable pytorch/executorch#3344 as shown on HUD https://hud.pytorch.org/hud/pytorch/executorch/main and Dr.CI applies the same logic on a PR pytorch/executorch#3318 to show the job as unstable.
🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3318
Note: Links to docs will display an error until the docs builds have been completed.
✅ You can merge normally! (1 Unrelated Failure)
As of commit f712e381c161901b733baa6b1fe7d85dc25404d3 with merge base b669056c1cff5f7fe3786df9e68a14447cd5410b (
):
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
Credentials could not be loaded, please check your action inputs: Could not load credentials from any providersThis comment was automatically generated by Dr. CI and updates every 15 minutes.