[mergebot] Set mergebot to be configured via config #5312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
ZainRizvi
approved these changes
Jun 11, 2024
| import { CachedConfigTracker } from "./utils"; | ||
|
|
||
| function pytorchBot(app: Probot): void { | ||
| const cachedConfigTracker = new CachedConfigTracker(app); |
Contributor
There was a problem hiding this comment.
any idea how long the cache is persisted?
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
It's not persisted at all, but repeated calls to config methods during execution of the command would not need to make new network calls to fetch the same info.
huydhn
approved these changes
Jun 11, 2024
Contributor
huydhn
left a comment
huydhn
left a comment
There was a problem hiding this comment.
LGTM! Pending your change on PT bot config
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jun 17, 2024
Fixes #ISSUE_NUMBER * Companion to pytorch/test-infra#5312 * See the above for details + possible risks * Without the above PR, this should have no effects Pull Request resolved: #128840 Approved by: https://github.com/huydhn
malfet
approved these changes
Jun 17, 2024
| import { CachedConfigTracker } from "./utils"; | ||
|
|
||
| function pytorchBot(app: Probot): void { | ||
| const cachedConfigTracker = new CachedConfigTracker(app); |
Contributor
There was a problem hiding this comment.
It's not persisted at all, but repeated calls to config methods during execution of the command would not need to make new network calls to fetch the same info.
Merged
clee2000
added a commit
to pytorch/ao
that referenced
this pull request
Jun 20, 2024
Tested locally using --dry-run Apparently there is precedent for just copying the files over (see executorch PR huy linked below), so this copies over trymerge + dependencies Removes check for release notes labels and sev Can merge both ghstack and normal PRs. Be warned though, PRs merged this way will show up as "closed" instead of "merged" on the github UI Future work: move trymerge + dependencies to test-infra (or download from pytorch), make sure its repo agnostic Depends on pytorch/test-infra#5312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For repos that want to merge via
@pytorchbot merge, the repo should putmergebot: Truein theirpytorch-probot.ymlIn preparation for letting torchao trigger their own merges through bot
Risks:
If we can't query for the config for some reason, it will not merge
todo before this gets merged:
Add
mergebot: Truein pytorch's config file