Skip to content

Update ExecuTorch install requirements to new APIs #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Jack-Khuu opened this issue Jan 28, 2025 · 2 comments
Closed

Update ExecuTorch install requirements to new APIs #1482

Jack-Khuu opened this issue Jan 28, 2025 · 2 comments
Assignees
@silverguo
Labels
actionable Items in the backlog waiting for an appropriate impl/fix ExecuTorch Issues related to ExecuTorch installation, export, or build. Mobile uses separate tags good first issue Good for newcomers triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@Jack-Khuu
Copy link
Contributor

Jack-Khuu commented Jan 28, 2025 •
edited
Loading

🚀 The feature, motivation and pitch

As a follow up from #1475, torchchat should verify whether the ExecuTorch install instructions properly reflect their new instructions.

Specifically ET:

  • renamed the original ./install_requirements to ./install_executorch (installs dependencies + pip installs)
  • Introduced a new ./install_requirements command that only installs the ET requirements

See pytorch/executorch#7730 for the relevant stack.

Alternatives

No response

Additional context

No response

RFC (Optional)

No response
@Jack-Khuu Jack-Khuu added actionable Items in the backlog waiting for an appropriate impl/fix ExecuTorch Issues related to ExecuTorch installation, export, or build. Mobile uses separate tags triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jan 28, 2025
@Jack-Khuu Jack-Khuu moved this from Ready to Staging in [torchchat] Looking for Contributors Feb 21, 2025
@Jack-Khuu Jack-Khuu moved this from Staging to Ready in [torchchat] Looking for Contributors Feb 21, 2025
@Jack-Khuu
Copy link
Contributor Author

Calling out that this may be a no-op:

In that case justify and verify that the existing instructions are sufficient

@Jack-Khuu Jack-Khuu added the good first issue Good for newcomers label Mar 7, 2025
@silverguo
Copy link
Contributor

It seems that most of works were done by pytorch/executorch#7730.
For installing ET from source, torchchat is doing the correct step by calling ./install_executorch.sh after cloning ET source code.
Installing with --pybind off is currently broken and sent a PR as a fix #1509

@Jack-Khuu Jack-Khuu moved this from Ready to In progress in [torchchat] Looking for Contributors Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silverguo silverguo

Labels
actionable Items in the backlog waiting for an appropriate impl/fix ExecuTorch Issues related to ExecuTorch installation, export, or build. Mobile uses separate tags good first issue Good for newcomers triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
[torchchat] Looking for Contributors
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jack-Khuu @silverguo