Skip to content

Commit 8c38842

Browse files
committed
Making value 0.0 by default for BC.
1 parent e0b3405 commit 8c38842

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

references/detection/train.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,11 @@ def main(args):
9393
collate_fn=utils.collate_fn)
9494

9595
print("Creating model")
96-
model = torchvision.models.detection.__dict__[args.model](num_classes=num_classes,
97-
pretrained=args.pretrained)
96+
kwargs = {}
97+
if "rcnn" in args.model:
98+
kwargs["rpn_score_thresh"] = 0.05
99+
model = torchvision.models.detection.__dict__[args.model](num_classes=num_classes, pretrained=args.pretrained,
100+
**kwargs)
98101
model.to(device)
99102

100103
model_without_ddp = model

test/test_onnx.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -368,8 +368,7 @@ def get_test_images(self):
368368
def test_faster_rcnn(self):
369369
images, test_images = self.get_test_images()
370370
dummy_image = [torch.ones(3, 100, 100) * 0.3]
371-
model = models.detection.faster_rcnn.fasterrcnn_resnet50_fpn(pretrained=True, min_size=200, max_size=300,
372-
rpn_score_thresh=0.0)
371+
model = models.detection.faster_rcnn.fasterrcnn_resnet50_fpn(pretrained=True, min_size=200, max_size=300)
373372
model.eval()
374373
model(images)
375374
# Test exported model on images of different size, or dummy input
@@ -420,8 +419,7 @@ def test_paste_mask_in_image(self):
420419
def test_mask_rcnn(self):
421420
images, test_images = self.get_test_images()
422421
dummy_image = [torch.ones(3, 100, 100) * 0.3]
423-
model = models.detection.mask_rcnn.maskrcnn_resnet50_fpn(pretrained=True, min_size=200, max_size=300,
424-
rpn_score_thresh=0.0)
422+
model = models.detection.mask_rcnn.maskrcnn_resnet50_fpn(pretrained=True, min_size=200, max_size=300)
425423
model.eval()
426424
model(images)
427425
# Test exported model on images of different size, or dummy input
@@ -471,8 +469,7 @@ def test_heatmaps_to_keypoints(self):
471469
def test_keypoint_rcnn(self):
472470
images, test_images = self.get_test_images()
473471
dummy_images = [torch.ones(3, 100, 100) * 0.3]
474-
model = models.detection.keypoint_rcnn.keypointrcnn_resnet50_fpn(pretrained=True, min_size=200, max_size=300,
475-
rpn_score_thresh=0.0)
472+
model = models.detection.keypoint_rcnn.keypointrcnn_resnet50_fpn(pretrained=True, min_size=200, max_size=300)
476473
model.eval()
477474
model(images)
478475
self.run_model(model, [(images,), (test_images,), (dummy_images,)],

torchvision/models/detection/faster_rcnn.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ def __init__(self, backbone, num_classes=None,
155155
rpn_nms_thresh=0.7,
156156
rpn_fg_iou_thresh=0.7, rpn_bg_iou_thresh=0.3,
157157
rpn_batch_size_per_image=256, rpn_positive_fraction=0.5,
158-
rpn_score_thresh=0.05,
158+
rpn_score_thresh=0.0,
159159
# Box parameters
160160
box_roi_pool=None, box_head=None, box_predictor=None,
161161
box_score_thresh=0.05, box_nms_thresh=0.5, box_detections_per_img=100,

torchvision/models/detection/keypoint_rcnn.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ def __init__(self, backbone, num_classes=None,
160160
rpn_nms_thresh=0.7,
161161
rpn_fg_iou_thresh=0.7, rpn_bg_iou_thresh=0.3,
162162
rpn_batch_size_per_image=256, rpn_positive_fraction=0.5,
163-
rpn_score_thresh=0.05,
163+
rpn_score_thresh=0.0,
164164
# Box parameters
165165
box_roi_pool=None, box_head=None, box_predictor=None,
166166
box_score_thresh=0.05, box_nms_thresh=0.5, box_detections_per_img=100,

torchvision/models/detection/mask_rcnn.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ def __init__(self, backbone, num_classes=None,
163163
rpn_nms_thresh=0.7,
164164
rpn_fg_iou_thresh=0.7, rpn_bg_iou_thresh=0.3,
165165
rpn_batch_size_per_image=256, rpn_positive_fraction=0.5,
166-
rpn_score_thresh=0.05,
166+
rpn_score_thresh=0.0,
167167
# Box parameters
168168
box_roi_pool=None, box_head=None, box_predictor=None,
169169
box_score_thresh=0.05, box_nms_thresh=0.5, box_detections_per_img=100,

0 commit comments

Comments
 (0)