Skip to content

Commit ade1cf7

Browse files
committed
Remove glog and try making ffmpeg finding more robust
1 parent 9b554f5 commit ade1cf7

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

setup.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
from pkg_resources import get_distribution, DistributionNotFound
88
import subprocess
99
import distutils.command.clean
10+
import distutils.spawn
1011
import glob
1112
import shutil
1213

@@ -135,8 +136,9 @@ def get_extensions():
135136

136137
# Packages install by conda will put header files in the include folder of
137138
# conda virtual environment
138-
conda_prefix = os.environ.get('CONDA_PREFIX')
139-
conda_include_dir = os.path.join(conda_prefix, 'include')
139+
ffmpeg_bin = os.path.dirname(distutils.spawn.find_executable('ffmpeg'))
140+
ffmpeg_root = os.path.dirname(ffmpeg_bin)
141+
ffmpeg_include_dir = os.path.join(ffmpeg_root, 'include')
140142

141143
# TorchVision video reader
142144
video_reader_src_dir = os.path.join(this_dir, 'torchvision', 'csrc', 'cpu', 'video_reader')
@@ -169,10 +171,10 @@ def get_extensions():
169171
video_reader_src,
170172
include_dirs=[
171173
video_reader_src_dir,
172-
conda_include_dir,
174+
ffmpeg_include_dir,
175+
extensions_dir,
173176
],
174177
libraries=[
175-
'glog',
176178
'avcodec',
177179
'avformat',
178180
'avutil',

torchvision/csrc/cpu/video_reader/FfmpegUtil.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#pragma once
22

33
#include <string>
4+
#include <array>
45
#include "FfmpegHeaders.h"
56
#include "Interface.h"
67

torchvision/csrc/cpu/video_reader/Interface.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include <glog/logging.h>
3+
#include <c10/util/Logging.h>
44
#include <sys/types.h>
55
#include <memory>
66
#include <unordered_map>

torchvision/csrc/cpu/video_reader/VideoReader.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#include "VideoReader.h"
22
#include <ATen/ATen.h>
3-
#include <glog/logging.h>
3+
#include <c10/util/Logging.h>
44
#include <exception>
55
#include "FfmpegDecoder.h"
66
#include "FfmpegHeaders.h"
@@ -152,7 +152,7 @@ torch::List<torch::Tensor> readVideo(
152152
int64_t audioTimeBaseDen) {
153153
if (!glog_initialized) {
154154
glog_initialized = true;
155-
google::InitGoogleLogging("VideoReader");
155+
// google::InitGoogleLogging("VideoReader");
156156
}
157157

158158
unique_ptr<DecoderParameters> params = util::getDecoderParams(

0 commit comments

Comments
 (0)