Skip to content

Commit ae9963f

Browse files
committed
[v0.9.1] Remove special versioning suffix rules for CUDA 10.2 (#3603)
* packaging: Remove special versioning priveleges Adds a version suffix for CUDA 10.2 for ease of installing when installing from download.pytorch.org Signed-off-by: Eli Uriegas <[email protected]> * also include windows cmath fix Signed-off-by: Eli Uriegas <[email protected]> * remove comment Signed-off-by: Eli Uriegas <[email protected]> * fix indent Signed-off-by: Eli Uriegas <[email protected]> * actually add the script Signed-off-by: Eli Uriegas <[email protected]>
1 parent 300a8a4 commit ae9963f

File tree

3 files changed

+61
-4
lines changed

3 files changed

+61
-4
lines changed

.circleci/config.yml

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,11 @@ jobs:
294294
- checkout_merge
295295
- designate_upload_channel
296296
- install_cuda_compatible_cmath
297+
- run:
298+
name: _HACK_ Install CUDA compatible cmath
299+
no_output_timeout: 1m
300+
command: |
301+
powershell .circleci/scripts/vs_install_cmath.ps1
297302
- run:
298303
name: Build conda packages
299304
no_output_timeout: 20m
@@ -322,6 +327,11 @@ jobs:
322327
- checkout_merge
323328
- designate_upload_channel
324329
- install_cuda_compatible_cmath
330+
- run:
331+
name: _HACK_ Install CUDA compatible cmath
332+
no_output_timeout: 1m
333+
command: |
334+
powershell .circleci/scripts/vs_install_cmath.ps1
325335
- run:
326336
name: Build wheel packages
327337
command: |
@@ -703,6 +713,11 @@ jobs:
703713
- checkout
704714
- designate_upload_channel
705715
- install_cuda_compatible_cmath
716+
- run:
717+
name: _HACK_ Install CUDA compatible cmath
718+
no_output_timeout: 1m
719+
command: |
720+
powershell .circleci/scripts/vs_install_cmath.ps1
706721
- run:
707722
name: Generate cache key
708723
# This will refresh cache on Sundays, nightly build should generate new cache.
@@ -745,6 +760,11 @@ jobs:
745760
- checkout
746761
- designate_upload_channel
747762
- install_cuda_compatible_cmath
763+
- run:
764+
name: _HACK_ Install CUDA compatible cmath
765+
no_output_timeout: 1m
766+
command: |
767+
powershell .circleci/scripts/vs_install_cmath.ps1
748768
- run:
749769
name: Generate cache key
750770
# This will refresh cache on Sundays, nightly build should generate new cache.
@@ -875,6 +895,11 @@ jobs:
875895
- checkout_merge
876896
- designate_upload_channel
877897
- install_cuda_compatible_cmath
898+
- run:
899+
name: _HACK_ Install CUDA compatible cmath
900+
no_output_timeout: 1m
901+
command: |
902+
powershell .circleci/scripts/vs_install_cmath.ps1
878903
- run:
879904
command: |
880905
set -ex
@@ -889,6 +914,11 @@ jobs:
889914
- checkout_merge
890915
- designate_upload_channel
891916
- install_cuda_compatible_cmath
917+
- run:
918+
name: _HACK_ Install CUDA compatible cmath
919+
no_output_timeout: 1m
920+
command: |
921+
powershell .circleci/scripts/vs_install_cmath.ps1
892922
- run:
893923
command: |
894924
set -ex

.circleci/config.yml.in

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,11 @@ jobs:
294294
- checkout_merge
295295
- designate_upload_channel
296296
- install_cuda_compatible_cmath
297+
- run:
298+
name: _HACK_ Install CUDA compatible cmath
299+
no_output_timeout: 1m
300+
command: |
301+
powershell .circleci/scripts/vs_install_cmath.ps1
297302
- run:
298303
name: Build conda packages
299304
no_output_timeout: 20m
@@ -322,6 +327,11 @@ jobs:
322327
- checkout_merge
323328
- designate_upload_channel
324329
- install_cuda_compatible_cmath
330+
- run:
331+
name: _HACK_ Install CUDA compatible cmath
332+
no_output_timeout: 1m
333+
command: |
334+
powershell .circleci/scripts/vs_install_cmath.ps1
325335
- run:
326336
name: Build wheel packages
327337
command: |
@@ -703,6 +713,11 @@ jobs:
703713
- checkout
704714
- designate_upload_channel
705715
- install_cuda_compatible_cmath
716+
- run:
717+
name: _HACK_ Install CUDA compatible cmath
718+
no_output_timeout: 1m
719+
command: |
720+
powershell .circleci/scripts/vs_install_cmath.ps1
706721
- run:
707722
name: Generate cache key
708723
# This will refresh cache on Sundays, nightly build should generate new cache.
@@ -745,6 +760,11 @@ jobs:
745760
- checkout
746761
- designate_upload_channel
747762
- install_cuda_compatible_cmath
763+
- run:
764+
name: _HACK_ Install CUDA compatible cmath
765+
no_output_timeout: 1m
766+
command: |
767+
powershell .circleci/scripts/vs_install_cmath.ps1
748768
- run:
749769
name: Generate cache key
750770
# This will refresh cache on Sundays, nightly build should generate new cache.
@@ -875,6 +895,11 @@ jobs:
875895
- checkout_merge
876896
- designate_upload_channel
877897
- install_cuda_compatible_cmath
898+
- run:
899+
name: _HACK_ Install CUDA compatible cmath
900+
no_output_timeout: 1m
901+
command: |
902+
powershell .circleci/scripts/vs_install_cmath.ps1
878903
- run:
879904
command: |
880905
set -ex
@@ -889,6 +914,11 @@ jobs:
889914
- checkout_merge
890915
- designate_upload_channel
891916
- install_cuda_compatible_cmath
917+
- run:
918+
name: _HACK_ Install CUDA compatible cmath
919+
no_output_timeout: 1m
920+
command: |
921+
powershell .circleci/scripts/vs_install_cmath.ps1
892922
- run:
893923
command: |
894924
set -ex

packaging/pkg_helpers.bash

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,7 @@ setup_cuda() {
3535
export WHEEL_DIR=""
3636
# Wheel builds need suffixes (but not if they're on OS X, which never has suffix)
3737
if [[ "$BUILD_TYPE" == "wheel" ]] && [[ "$(uname)" != Darwin ]]; then
38-
# The default CUDA has no suffix
39-
if [[ "$CU_VERSION" != "cu102" ]]; then
40-
export PYTORCH_VERSION_SUFFIX="+$CU_VERSION"
41-
fi
38+
export PYTORCH_VERSION_SUFFIX="+$CU_VERSION"
4239
# Match the suffix scheme of pytorch, unless this package does not have
4340
# CUDA builds (in which case, use default)
4441
if [[ -z "$NO_CUDA_PACKAGE" ]]; then

0 commit comments

Comments
 (0)