Minor refactoring based on static analysis on the code of *ROIAlign: (#2892)

datumbox · web-flow · commit d8ccbe7ec11e · 2020-10-26T13:23:18.000+01:00
- Remove unnecessary return.
diff --git a/torchvision/csrc/cpu/PSROIAlign_cpu.cpp b/torchvision/csrc/cpu/PSROIAlign_cpu.cpp
@@ -194,8 +194,6 @@ void bilinear_interpolate_gradient(
   // T val = (w1 * v1 + w2 * v2 + w3 * v3 + w4 * v4);
 
   w1 = hy * hx, w2 = hy * lx, w3 = ly * hx, w4 = ly * lx;
-
-  return;
 }
 
 template <class T>
diff --git a/torchvision/csrc/cpu/ROIAlign_cpu.cpp b/torchvision/csrc/cpu/ROIAlign_cpu.cpp
@@ -269,8 +269,6 @@ void bilinear_interpolate_gradient(
   // T val = (w1 * v1 + w2 * v2 + w3 * v3 + w4 * v4);
 
   w1 = hy * hx, w2 = hy * lx, w3 = ly * hx, w4 = ly * lx;
-
-  return;
 }
 
 template <class T>
diff --git a/torchvision/csrc/cuda/PSROIAlign_cuda.cu b/torchvision/csrc/cuda/PSROIAlign_cuda.cu
@@ -192,8 +192,6 @@ __device__ void bilinear_interpolate_gradient(
   // T val = (w1 * v1 + w2 * v2 + w3 * v3 + w4 * v4);
 
   w1 = hy * hx, w2 = hy * lx, w3 = ly * hx, w4 = ly * lx;
-
-  return;
 }
 
 template <typename T>
diff --git a/torchvision/csrc/cuda/ROIAlign_cuda.cu b/torchvision/csrc/cuda/ROIAlign_cuda.cu
@@ -194,8 +194,6 @@ __device__ void bilinear_interpolate_gradient(
   // T val = (w1 * v1 + w2 * v2 + w3 * v3 + w4 * v4);
 
   w1 = hy * hx, w2 = hy * lx, w3 = ly * hx, w4 = ly * lx;
-
-  return;
 }
 
 template <typename T>

Original file line number	Diff line number	Diff line change
`@@ -194,8 +194,6 @@ void bilinear_interpolate_gradient(`
`194`	`194`	`// T val = (w1 * v1 + w2 * v2 + w3 * v3 + w4 * v4);`
`195`	`195`
`196`	`196`	`w1 = hy * hx, w2 = hy * lx, w3 = ly * hx, w4 = ly * lx;`
`197`		`-`
`198`		`- return;`
`199`	`197`	`}`
`200`	`198`
`201`	`199`	`template <class T>`
Original file line number	Diff line number	Diff line change
`@@ -269,8 +269,6 @@ void bilinear_interpolate_gradient(`
`269`	`269`	`// T val = (w1 * v1 + w2 * v2 + w3 * v3 + w4 * v4);`
`270`	`270`
`271`	`271`	`w1 = hy * hx, w2 = hy * lx, w3 = ly * hx, w4 = ly * lx;`
`272`		`-`
`273`		`- return;`
`274`	`272`	`}`
`275`	`273`
`276`	`274`	`template <class T>`
Original file line number	Diff line number	Diff line change
`@@ -192,8 +192,6 @@ __device__ void bilinear_interpolate_gradient(`
`192`	`192`	`// T val = (w1 * v1 + w2 * v2 + w3 * v3 + w4 * v4);`
`193`	`193`
`194`	`194`	`w1 = hy * hx, w2 = hy * lx, w3 = ly * hx, w4 = ly * lx;`
`195`		`-`
`196`		`- return;`
`197`	`195`	`}`
`198`	`196`
`199`	`197`	`template <typename T>`
Original file line number	Diff line number	Diff line change
`@@ -194,8 +194,6 @@ __device__ void bilinear_interpolate_gradient(`
`194`	`194`	`// T val = (w1 * v1 + w2 * v2 + w3 * v3 + w4 * v4);`
`195`	`195`
`196`	`196`	`w1 = hy * hx, w2 = hy * lx, w3 = ly * hx, w4 = ly * lx;`
`197`		`-`
`198`		`- return;`
`199`	`197`	`}`
`200`	`198`
`201`	`199`	`template <typename T>`