some more

Author: NicolasHug

torchvision/prototype/models/detection/faster_rcnn.py

@@ -203,6 +203,11 @@ def fasterrcnn_mobilenet_v3_large_320_fpn(
 ) -> FasterRCNN:
     if "pretrained" in kwargs:
         warnings.warn("The argument pretrained is deprecated, please use weights instead.")
+        # These long weight names are a bit of a mouthful lol
+        # I don't have a better proposal TBH.
+        # I think the complexity of those weight names can be greatly reduced by:
+        # - good docs (which I know is part of the future work)
+        # - good defaults like "pretrained" or "latest" or whatever is easy to remember for the user, as suggested in another comment
         weights = FasterRCNNMobileNetV3Large320FPNWeights.Coco_RefV1 if kwargs.pop("pretrained") else None
     weights = FasterRCNNMobileNetV3Large320FPNWeights.verify(weights)
     if "pretrained_backbone" in kwargs:

torchvision/prototype/models/resnet.py

@@ -248,7 +248,7 @@ def resnet18(weights: Optional[ResNet18Weights] = None, progress: bool = True, *
     # This would make sure the warning message is consistent, avoid code duplication, etc.
     if "pretrained" in kwargs:
         # Nit: "argument" should probably be "parameter", since the term
-        # "argument" refers to the _value_ of the parameter at call time.
+        # "argument" refers to the *value* of the parameter at call time.
         warnings.warn("The 'pretrained' parameter is deprecated, please use the 'weights' parameter instead.")
         weights = ResNet18Weights.ImageNet1K_RefV1 if kwargs.pop("pretrained") else None