The description of returned tensor's size in ps_roi_pool.py and ps_roi_align.py are wrong #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

chengjuzhou opened this issue May 17, 2021 · 2 comments

Labels

bug module: documentation

Contributor

chengjuzhou commented May 17, 2021 •

edited

Loading

📚 Documentation

The size of returned tensor should be

[K, C/(output_size[0]*output_size[1]), output_sizep[0], output_size[1]]

in
https://github.com/pytorch/vision/blob/master/torchvision/ops/ps_roi_align.py#L42
and
https://github.com/pytorch/vision/blob/master/torchvision/ops/ps_roi_pool.py#L36

This can be verified from
https://github.com/pytorch/vision/blob/master/test/test_ops.py#L186
and
https://github.com/pytorch/vision/blob/master/test/test_ops.py#L390

datumbox added bug module: documentation labels

Contributor

datumbox commented May 17, 2021

@chengjuzhou Good spot, thanks for flagging it!

Would you like to send us a PR that fixes this?

Member

fmassa commented May 17, 2021

Fixed in #3849, thanks @chengjuzhou !

fmassa closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment