From b26af3ee183094b1e5d53a13332e0ceb614504c7 Mon Sep 17 00:00:00 2001 From: Aditya Oke Date: Tue, 12 Oct 2021 22:13:41 +0530 Subject: [PATCH 1/2] Add typing for imagelist, move params to docstring --- mypy.ini | 4 ---- torchvision/models/detection/image_list.py | 11 +++++------ 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/mypy.ini b/mypy.ini index 0c46a09610b..dbcaab8770c 100644 --- a/mypy.ini +++ b/mypy.ini @@ -25,10 +25,6 @@ ignore_errors = True ignore_errors = True -[mypy-torchvision.models.detection.image_list] - -ignore_errors = True - [mypy-torchvision.models.detection.transform] ignore_errors = True diff --git a/torchvision/models/detection/image_list.py b/torchvision/models/detection/image_list.py index 333d3b569f2..c310e79fc14 100644 --- a/torchvision/models/detection/image_list.py +++ b/torchvision/models/detection/image_list.py @@ -10,14 +10,13 @@ class ImageList(object): varying sizes) as a single tensor. This works by padding the images to the same size, and storing in a field the original sizes of each image + + Args: + tensors (tensor) + image_sizes (list[tuple[int, int]]) """ - def __init__(self, tensors: Tensor, image_sizes: List[Tuple[int, int]]): - """ - Args: - tensors (tensor) - image_sizes (list[tuple[int, int]]) - """ + def __init__(self, tensors: Tensor, image_sizes: List[Tuple[int, int]]) -> None: self.tensors = tensors self.image_sizes = image_sizes From 2e75d8722dd8a00acd0876ff554ff38bd07aee6d Mon Sep 17 00:00:00 2001 From: Aditya Oke Date: Tue, 12 Oct 2021 23:28:23 +0530 Subject: [PATCH 2/2] Add docs --- torchvision/models/detection/image_list.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/torchvision/models/detection/image_list.py b/torchvision/models/detection/image_list.py index c310e79fc14..58f32662b1a 100644 --- a/torchvision/models/detection/image_list.py +++ b/torchvision/models/detection/image_list.py @@ -12,8 +12,8 @@ class ImageList(object): and storing in a field the original sizes of each image Args: - tensors (tensor) - image_sizes (list[tuple[int, int]]) + tensors (tensor): Tensor containing images. + image_sizes (list[tuple[int, int]]): List of Tuples each containing size of images. """ def __init__(self, tensors: Tensor, image_sizes: List[Tuple[int, int]]) -> None: