Skip to content

Add installation instructions to benchmarks/README.md #9118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
haifeng-jin opened this issue May 8, 2025 · 1 comment · Fixed by #9230
Closed

Add installation instructions to benchmarks/README.md #9118

haifeng-jin opened this issue May 8, 2025 · 1 comment · Fixed by #9230

Comments

@haifeng-jin
Copy link
Collaborator

📚 Documentation

The benchmarks/README.md does not contain the installation instructions, which is crucial for running the benchmarks.

It requires installing the pytorch/benchmark repo and other libraries like libGL (required by Llava).

Solution

Add the instructions to benchmarks/README.md.
Install pytorch/benchmark as a library.
Install libGL.
Install any other requirements.

To verify, make sure the instructions work with the devcontainer.

@haifeng-jin haifeng-jin self-assigned this May 8, 2025
@haifeng-jin haifeng-jin changed the title [benchmarks] Add installation instructions to benchmarks/README.md Add installation instructions to benchmarks/README.md May 8, 2025
@ysiraichi
Copy link
Collaborator

I did work on this at some point (link). Although the PR was never merged, feel free to pick things from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants