Add coverage for Issue

Author: jpignata

config/cops.yml

@@ -2,15 +2,17 @@ Metrics/AbcSize:
   base_points: 1_000_000
   overage_points: 70_000
 Metrics/BlockNesting:
-  remediation_points: 100_000
+  base_points: 100_000
+  overage_points: 50_000
 Metrics/ClassLength:
   base_points: 5_000_000
   overage_points: 35_000
 Metrics/CyclomaticComplexity:
   base_points: 1_000_000
   overage_points: 70_000
 Metrics/LineLength:
-  remediation_points: 50_000
+  base_points: 50_000
+  overage_points: 0
 Metrics/MethodLength:
   base_points: 1_000_000
   overage_points: 70_000

lib/cc/engine/issue.rb

@@ -12,6 +12,7 @@ class Issue < SimpleDelegator
       def initialize(issue, path, cop_list: nil)
         @path = path
         @cop_list = cop_list
+
         super(issue)
       end
 
@@ -73,8 +74,8 @@ def overage_points
 
       def multiplier
         result = message.scan(MULTIPLIER_REGEX)
-        score, max = result[0]
-        score.to_i - max.to_i
+        score, threshold = result[0]
+        score.to_i - threshold.to_i
       end
 
       def category
@@ -94,29 +95,25 @@ def positions
         }
       end
 
-      # Increment column value as columns are 0-based in parser
+      # Increments column values as columns are 0-based in parser
       def columns
         return @columns if defined?(@columns)
 
-        if location.is_a?(RuboCop::Cop::Lint::Syntax::PseudoSourceRange)
-          @columns = [location.column + 1, location.column + 1]
-        else
-          @columns = [location.column + 1, location.last_column + 1]
-        end
+        end_column = location.try(:last_column) || location.column
+        @columns = [location.column + 1, end_column + 1]
       end
 
       def lines
         return @lines if defined?(@lines)
 
-        if location.is_a?(RuboCop::Cop::Lint::Syntax::PseudoSourceRange)
-          @lines = [location.line, location.line]
-        else
-          @lines = [location.first_line, location.last_line]
-        end
+        begin_line = location.try(:first_line) || location.line
+        end_line = location.try(:last_line) || location.line
+        @lines = [begin_line, end_line]
       end
 
       def content_body
         return @content_body if defined?(@content_body)
+
         content_path = expand_config_path("contents/#{cop_name.underscore}.md")
         @content_body = File.exist?(content_path) && File.read(content_path)
       end

spec/cc/engine/issue_spec.rb

@@ -3,6 +3,41 @@
 
 module CC::Engine
   describe Issue do
+    describe "#to_json" do
+      let(:issue) do
+        location = OpenStruct.new
+        location.first_line = 10
+        location.last_line = 10
+        location.column = 3
+        location.last_column = 99
+
+        offense = OpenStruct.new
+        offense.cop_name = "Metrics/LineLength"
+        offense.message = "Line too long [100/80]"
+        offense.location = location
+
+        Issue.new(offense, "app/models/user.rb")
+      end
+
+      it "returns a json issue for a Rubocop offense" do
+        attributes = JSON.parse(issue.to_json)
+
+        expect(attributes["type"]).to eq("Issue")
+        expect(attributes["check_name"]).to eq("Rubocop/Metrics/LineLength")
+        expect(attributes["description"]).to eq("Line too long [100/80]")
+        expect(attributes["categories"]).to eq(["Style"])
+        expect(attributes["remediation_points"]).to eq(50_000)
+        expect(attributes["location"]["path"]).to eq("app/models/user.rb")
+        expect(attributes["location"]["positions"]["begin"]["line"]).to eq(10)
+        expect(attributes["location"]["positions"]["end"]["line"]).to eq(10)
+        expect(attributes["location"]["positions"]["begin"]["column"]).to eq(4)
+        expect(attributes["location"]["positions"]["end"]["column"]).to eq(100)
+        expect(attributes["content"]["body"]).to include(
+          "This cop checks the length of lines in the source code."
+        )
+      end
+    end
+
     describe "#remediation points" do
       describe "cop has configured remediation points" do
         describe "without a multiplier" do