address comments

Author: NoureldinYosri

cirq-core/cirq/protocols/json_serialization_test.py

@@ -24,6 +24,7 @@
 from typing import Dict, List, Optional, Tuple, Type
 from unittest import mock
 
+import attrs
 import networkx as nx
 import numpy as np
 import pandas as pd
@@ -790,3 +791,15 @@ def test_datetime():
     assert re_pst_dt == pst_dt
     assert re_pst_dt == utc_dt
     assert re_pst_dt == re_naive_dt
+
+
+@attrs.frozen
+class _TestAttrsClas:
+    name: str
+    x: int
+
+
+def test_attrs_json_dict():
+    obj = _TestAttrsClas('test', x=123)
+    js = json_serialization.attrs_json_dict(obj)
+    assert js == {'name': 'test', 'x': 123}

cirq-core/cirq/value/condition.py

@@ -151,6 +151,9 @@ class BitMaskKeyCondition(Condition):
         - BitMaskKeyCondition.create_equal_mask('a', 13) -> (a & 13) == 13
         - BitMaskKeyCondition.create_not_equal_mask('a', 13) -> (a & 13) != 13
 
+    The bits in the bitmask have the same order as the qubits passed to `cirq.measure(...)`. That's the
+    most significant bit corresponds to the the first (left most) qubit.
+
     Attributes:
         - key: Measurement key.
         - index: integer index (same as KeyCondition.index).
@@ -179,6 +182,7 @@ def keys(self):
     def create_equal_mask(
         key: 'cirq.MeasurementKey', bitmask: int, *, index: int = -1
     ) -> 'BitMaskKeyCondition':
+        """Creates a condition that evaluates (meas & bitmask) == bitmask."""
         return BitMaskKeyCondition(
             key, index, target_value=bitmask, equal_target=True, bitmask=bitmask
         )
@@ -187,6 +191,7 @@ def create_equal_mask(
     def create_not_equal_mask(
         key: 'cirq.MeasurementKey', bitmask: int, *, index: int = -1
     ) -> 'BitMaskKeyCondition':
+        """Creates a condition that evaluates (meas & bitmask) != bitmask."""
         return BitMaskKeyCondition(
             key, index, target_value=bitmask, equal_target=False, bitmask=bitmask
         )