Merged
Conversation
Collaborator
Author
|
I wonder whether this is a breaking change with regards to the PVP?
Do these changes constitute proper changes to "the definitions of datatypes"? The derived |
sjakobi
commented
Feb 2, 2020
We don't actually scrutinize these so often.
sjakobi
force-pushed
the
unpack-fields
branch
from
aaeb74b to
4fda01d
Compare
Collaborator
|
Strictly speaking, this is a major bump. On the plus side, many changes in prettyprinter warrant major bumps, so this can be packed with another major change, no need for its own release. |
sjakobi
commented
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an earlier iteration I had also
UNPACKed someTextfields. But then I noticed that we don't actually look at them so often, so I assumed it's not worth it.Context: #121