Skip to content

Casing consistency of theme properties #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lionel- opened this issue Jun 16, 2022 · 2 comments
Closed

Casing consistency of theme properties #483

lionel- opened this issue Jun 16, 2022 · 2 comments
Milestone
3.4.0

Comments

@lionel-
Copy link
Member

lionel- commented Jun 16, 2022

Most properties are dash-cased except these ones which are snake_cased: vec_last, vec_sep, vec_trunc, and string_quote. Should the latter be superseded in favour of dash-cased properties?
@lionel-
Copy link
Member Author

lionel- commented Jun 17, 2022

Maybe also replace all dashes by underscores in property values, so that color = "br-blue" is equivalent to color = "br_blue"?

@gaborcsardi gaborcsardi added this to the 3.4.0 milestone Aug 23, 2022
@gaborcsardi
Copy link
Member

Many style names are coming from CSS, so I will rather change the underscores into dashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

No branches or pull requests
2 participants
@gaborcsardi @lionel-