Skip to content

quotes_linter() #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MichaelChirico opened this issue Oct 17, 2022 · 2 comments · Fixed by #1931
Closed

quotes_linter() #1729

MichaelChirico opened this issue Oct 17, 2022 · 2 comments · Fixed by #1931
Labels
breaking change ☠️ API change likely to affect existing code feature a feature request or enhancement

Comments

@MichaelChirico
Copy link
Collaborator

I think it makes sense to offer a generalized version of single_quotes_linter() that allows users to choose ' as their preferred quoting character. Of course " should be the default.
@MichaelChirico MichaelChirico added feature a feature request or enhancement breaking change ☠️ API change likely to affect existing code labels Oct 17, 2022
@MichaelChirico MichaelChirico added this to the 3.1.0 milestone Oct 17, 2022
@IndrajeetPatil
Copy link
Collaborator

This'd be a breaking change because we plan to deprecate single_quotes_linter() in favour of something like quotes_linter(quote = '"')?

@MichaelChirico
Copy link
Collaborator Author

yes

@MichaelChirico MichaelChirico mentioned this issue Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change ☠️ API change likely to affect existing code feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New quotes_linter() to replace single_quotes_linter() r-lib/lintr
2 participants
@MichaelChirico @IndrajeetPatil