Unstated pillar version requirement? #1794

MichaelChirico · 2025-04-18T23:42:27Z

I tried updating {rlang} 1.1.5 --> 1.1.6 and I am seeing this test failure:

expr_deparse(~foo) (`actual`) not equal to "<formula>" (`expected`). ('test-deparse.R:848:3')
--------------------------------------------------------------------------------
expr_deparse(~foo) (`actual`) not equal to "<formula>" (`expected`).

`actual`:   "<S3: formula>"
`expected`: "<formula>"

~~I have pillar 1.10.0, is >1.10.0 required?~~

I updated pillar too, to no avail, any ideas?

The text was updated successfully, but these errors were encountered:

musvaage · 2025-04-21T16:04:28Z

R version 4.5.0
rlang-1.1.6.tar.gz

On my Linux box cd'ing into the extracted .tar.gz and running devtools::test() did not return any failed tests.

MichaelChirico · 2025-04-21T16:39:20Z

Thanks! Could you share your full session info (including versions of all loaded packages)?

musvaage · 2025-04-21T19:17:10Z

Could you share your full session info (including versions of all loaded packages)?

Perhaps this shell output suffices.

$ gcc --version | sed 1q && R --version | sed 1q
gcc (GCC) 11.2.0
R version 4.5.0 (2025-04-11) -- "How About a Twenty-Six"
$ R -q
> install.packages("devtools", quiet = TRUE)
also installing the dependencies ‘Rcpp’, ‘utf8’, ‘askpass’, ‘credentials’, ‘sys’, ‘zip’, ‘gitcreds’, ‘ini’, ‘fastmap’, ‘httpuv’, ‘mime’, ‘xtable’, ‘sourcetools’, ‘later’, ‘promises’, ‘base64enc’, ‘jquerylib’, ‘sass’, ‘fansi’, ‘systemfonts’, ‘textshaping’, ‘tinytex’, ‘xfun’, ‘pillar’, ‘pkgconfig’, ‘highr’, ‘diffobj’, ‘clipr’, ‘crayon’, ‘curl’, ‘gert’, ‘gh’, ‘glue’, ‘jsonlite’, ‘purrr’, ‘rappdirs’, ‘rprojroot’, ‘rstudioapi’, ‘whisker’, ‘yaml’, ‘R6’, ‘cachem’, ‘shiny’, ‘htmltools’, ‘callr’, ‘processx’, ‘bslib’, ‘digest’, ‘downlit’, ‘fontawesome’, ‘httr2’, ‘openssl’, ‘ragg’, ‘rmarkdown’, ‘tibble’, ‘xml2’, ‘htmlwidgets’, ‘vctrs’, ‘prettyunits’, ‘xopen’, ‘brew’, ‘commonmark’, ‘knitr’, ‘stringi’, ‘stringr’, ‘cpp11’, ‘brio’, ‘evaluate’, ‘magrittr’, ‘praise’, ‘ps’, ‘waldo’, ‘usethis’, ‘cli’, ‘desc’, ‘ellipsis’, ‘fs’, ‘lifecycle’, ‘memoise’, ‘miniUI’, ‘pkgbuild’, ‘pkgdown’, ‘pkgload’, ‘profvis’, ‘rcmdcheck’, ‘remotes’, ‘rlang’, ‘roxygen2’, ‘rversions’, ‘sessioninfo’, ‘testthat’, ‘urlchecker’, ‘withr’

Updating HTML index of packages in '.Library'
Making 'packages.html' ... done
> q()
Save workspace image? [y/n/c]: n
$ cd /tmp; tar xf rlang-1.1.6.tar.gz; cd rlang-1.1.6
$ R --no-echo -e 'devtools::test()'
ℹ Testing rlang
✔ | F W  S  OK | Context
✔ |         74 | arg [4.3s]                                                                                                                                            
✔ |         47 | attr                                                                                                                                                  
✔ |         63 | bytes                                                                                                                                                 
✔ |      1 358 | c-api [3.0s]                                                                                                                                          
✔ |      1 315 | call [2.6s]                                                                                                                                           
✔ |        132 | cnd-abort [28.2s]                                                                                                                                     
⠏ |          0 | cnd-entrace                                                                                                                                           

✔ |      1  43 | cnd-entrace [6.3s]                                                                                                                                    
✔ |         32 | cnd-handlers [2.7s]                                                                                                                                   
✔ |         76 | cnd-message [5.6s]                                                                                                                                    
✔ |         87 | cnd-signal [5.0s]                                                                                                                                     
✔ |         66 | cnd [6.0s]                                                                                                                                            
✔ |        261 | deparse [3.5s]                                                                                                                                        
✔ |         41 | deprecated-vec-squash                                                                                                                                 
✔ |      1  53 | deprecated                                                                                                                                            
✔ |         35 | dots-ellipsis [1.8s]                                                                                                                                  
✔ |      2 110 | dots [1.9s]                                                                                                                                           
✔ |      3   1 | encoding                                                                                                                                              
<U+2807> |      1  88 | env-binding                                                                                                                                    ✔ |      2 111 | env-binding [1.6s]                                                                                                                                    
✔ |         31 | env-special                                                                                                                                           
✔ |        160 | env [1.9s]                                                                                                                                            
✔ |        136 | eval-tidy [2.9s]                                                                                                                                      
✔ |          8 | eval                                                                                                                                                  
✔ |         36 | expr                                                                                                                                                  
✔ |        113 | fn [2.0s]                                                                                                                                             
✔ |         34 | formula                                                                                                                                               
✔ |         40 | friendly-type                                                                                                                                         
✔ |          9 | hash                                                                                                                                                  
✔ |         25 | lifecycle                                                                                                                                             
✔ |         30 | names [1.2s]                                                                                                                                          
✔ |         36 | node                                                                                                                                                  
✔ |      1 166 | nse-defuse [2.3s]                                                                                                                                     
✔ |        285 | nse-inject [3.5s]                                                                                                                                     
✔ |         10 | obj                                                                                                                                                   
✔ |         27 | operators                                                                                                                                             
✔ |         16 | parse                                                                                                                                                 
✔ |         99 | quo [1.3s]                                                                                                                                            
✔ |          3 | raw                                                                                                                                                   
✔ |         48 | s3                                                                                                                                                    
✔ |         60 | session [2.6s]                                                                                                                                        
✔ |         24 | stack                                                                                                                                                 
✔ |         39 | standalone-cli [2.7s]                                                                                                                                 
✔ |         18 | standalone-downstream-deps                                                                                                                            
✔ |      1   6 | standalone-obj-type                                                                                                                                   
✔ |         31 | standalone-purrr                                                                                                                                      
✔ |         15 | standalone-rlang                                                                                                                                      
✔ |          3 | standalone-s3-register                                                                                                                                
✔ |        143 | standalone-types-check [8.1s]                                                                                                                         
✔ |        136 | standalone-vctrs [1.1s]                                                                                                                               
✔ |          6 | standalone-zeallot                                                                                                                                    
✔ |         22 | standalone                                                                                                                                            
✔ |         11 | state                                                                                                                                                 
✔ |         18 | sym                                                                                                                                                   
✔ |         93 | trace [9.3s]                                                                                                                                          
✔ |        140 | types                                                                                                                                                 
✔ |      1  19 | utils                                                                                                                                                 
✔ |         57 | vec-new                                                                                                                                               
✔ |          6 | vec-utils                                                                                                                                             
✔ |         30 | vec                                                                                                                                                   
✔ |         14 | weakref                                                                                                                                               

══ Results ════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Duration: 123.2 s

── Skipped tests (14) ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• Can't profile memory on this system. (2): test-dots.R:394:3, test-dots.R:408:5
• Cannot set MBCS locale (1): test-utils.R:4:15
• Disabled (1): test-call.R:322:3
• Failing (1): test-env-binding.R:279:3
• No UTF-8 marker with this version of libiconv. (5): test-deprecated.R:17:3, test-encoding.R:2:3, test-encoding.R:19:3, test-env-binding.R:430:5,
  test-nse-defuse.R:270:3
• Not on Windows (1): test-encoding.R:28:3
• getRversion() >= "4.0" is TRUE (1): test-cnd-entrace.R:346:3
• has_private_accessors() is not TRUE (1): test-c-api.R:1197:3
• {S7} is not installed (1): test-standalone-obj-type.R:19:3

[ FAIL 0 | WARN 0 | SKIP 14 | PASS 4108 ]
$

musvaage · 2025-04-21T19:18:39Z

Could you share your full session info (including versions of all loaded packages)?

Here's the list of packages downloaded resultant of running install.packages("devtools", quiet = TRUE).

$ ls /tmp/R*/downloaded_packages
R6_2.6.1.tar.gz
Rcpp_1.0.14.tar.gz
askpass_1.2.1.tar.gz
base64enc_0.1-3.tar.gz
brew_1.0-10.tar.gz
brio_1.1.5.tar.gz
bslib_0.9.0.tar.gz
cachem_1.1.0.tar.gz
callr_3.7.6.tar.gz
cli_3.6.4.tar.gz
clipr_0.8.0.tar.gz
commonmark_1.9.5.tar.gz
cpp11_0.5.2.tar.gz
crayon_1.5.3.tar.gz
credentials_2.0.2.tar.gz
curl_6.2.2.tar.gz
desc_1.4.3.tar.gz
devtools_2.4.5.tar.gz
diffobj_0.3.5.tar.gz
digest_0.6.37.tar.gz
downlit_0.4.4.tar.gz
ellipsis_0.3.2.tar.gz
evaluate_1.0.3.tar.gz
fansi_1.0.6.tar.gz
fastmap_1.2.0.tar.gz
fontawesome_0.5.3.tar.gz
fs_1.6.6.tar.gz
gert_2.1.5.tar.gz
gh_1.4.1.tar.gz
gitcreds_0.1.2.tar.gz
glue_1.8.0.tar.gz
highr_0.11.tar.gz
htmltools_0.5.8.1.tar.gz
htmlwidgets_1.6.4.tar.gz
httpuv_1.6.16.tar.gz
httr2_1.1.2.tar.gz
ini_0.3.1.tar.gz
jquerylib_0.1.4.tar.gz
jsonlite_2.0.0.tar.gz
knitr_1.50.tar.gz
later_1.4.2.tar.gz
lifecycle_1.0.4.tar.gz
magrittr_2.0.3.tar.gz
memoise_2.0.1.tar.gz
mime_0.13.tar.gz
miniUI_0.1.2.tar.gz
openssl_2.3.2.tar.gz
pillar_1.10.2.tar.gz
pkgbuild_1.4.7.tar.gz
pkgconfig_2.0.3.tar.gz
pkgdown_2.1.1.tar.gz
pkgload_1.4.0.tar.gz
praise_1.0.0.tar.gz
prettyunits_1.2.0.tar.gz
processx_3.8.6.tar.gz
profvis_0.4.0.tar.gz
promises_1.3.2.tar.gz
ps_1.9.1.tar.gz
purrr_1.0.4.tar.gz
ragg_1.4.0.tar.gz
rappdirs_0.3.3.tar.gz
rcmdcheck_1.4.0.tar.gz
remotes_2.5.0.tar.gz
rlang_1.1.6.tar.gz
rmarkdown_2.29.tar.gz
roxygen2_7.3.2.tar.gz
rprojroot_2.0.4.tar.gz
rstudioapi_0.17.1.tar.gz
rversions_2.1.2.tar.gz
sass_0.4.10.tar.gz
sessioninfo_1.2.3.tar.gz
shiny_1.10.0.tar.gz
sourcetools_0.1.7-1.tar.gz
stringi_1.8.7.tar.gz
stringr_1.5.1.tar.gz
sys_3.4.3.tar.gz
systemfonts_1.2.2.tar.gz
testthat_3.2.3.tar.gz
textshaping_1.0.0.tar.gz
tibble_3.2.1.tar.gz
tinytex_0.57.tar.gz
urlchecker_1.0.1.tar.gz
usethis_3.1.0.tar.gz
utf8_1.2.4.tar.gz
vctrs_0.6.5.tar.gz
waldo_0.6.1.tar.gz
whisker_0.4.1.tar.gz
withr_3.0.2.tar.gz
xfun_0.52.tar.gz
xml2_1.3.8.tar.gz
xopen_1.0.1.tar.gz
xtable_1.8-4.tar.gz
yaml_2.3.10.tar.gz
zip_2.3.2.tar.gz
$

MichaelChirico · 2025-04-21T19:23:39Z

Unfortunately that's too noisy -- {devtools} installs way more packages than needed to just run {rlang}'s suite. We are out of date on 20-30 of those packages. It would be more helpful to do:

library(rlang)
library(testthat)
test_dir("tests")
sessionInfo()

MichaelChirico · 2025-04-21T19:27:39Z

OK, I understand. There's not a version requirement, but a requirement {pillar} be available for the tests. This is pretty opaque in the current suite.

musvaage · 2025-04-21T19:57:35Z

more helpful

My colleague who also had devtools version 2.4.5 installed ran this for you.

$ export LANG=en_GB.UTF-8
$ cd /tmp/rlang-1.1.6
$ R -q
> library(rlang)
> library(testthat)

Attaching package: ‘testthat’

The following objects are masked from ‘package:rlang’:

    is_false, is_null, is_true

> test_dir("tests")
✔ | F W  S  OK | Context
⠏ |          0 | testthat                                                                                                                                              

[ FAIL 0 | WARN 0 | SKIP 14 | PASS 4108 ]

══ Skipped tests (14) ═════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
• Can't profile memory on this system. (2): test-dots.R:394:3, test-dots.R:408:5
• Cannot set MBCS locale (1): test-utils.R:4:15
• Disabled (1): test-call.R:322:3
• Failing (1): test-env-binding.R:279:3
• No UTF-8 marker with this version of libiconv. (5): test-deprecated.R:17:3, test-encoding.R:2:3, test-encoding.R:19:3, test-env-binding.R:430:5,
  test-nse-defuse.R:270:3
• Not on Windows (1): test-encoding.R:28:3
• getRversion() >= "4.0" is TRUE (1): test-cnd-entrace.R:346:3
• has_private_accessors() is not TRUE (1): test-c-api.R:1197:3
• {S7} is not installed (1): test-standalone-obj-type.R:19:3

[ FAIL 0 | WARN 0 | SKIP 14 | PASS 4108 ]

══ Results ════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Duration: 121.7 s

[ FAIL 0 | WARN 0 | SKIP 0 | PASS 0 ]
> sessionInfo()
R version 4.5.0 (2025-04-11)
Platform: x86_64-slackware-linux-gnu
Running under: Slackware 15.0 x86_64

Matrix products: default
BLAS:   /home/peter/R/lib64/R/lib/libRblas.so 
LAPACK: /home/peter/R/lib64/R/lib/libRlapack.so;  LAPACK version 3.12.1

locale:
 [1] LC_CTYPE=en_GB.UTF-8       LC_NUMERIC=C              
 [3] LC_TIME=en_GB.UTF-8        LC_COLLATE=C              
 [5] LC_MONETARY=en_GB.UTF-8    LC_MESSAGES=en_GB.UTF-8   
 [7] LC_PAPER=en_GB.UTF-8       LC_NAME=C                 
 [9] LC_ADDRESS=C               LC_TELEPHONE=C            
[11] LC_MEASUREMENT=en_GB.UTF-8 LC_IDENTIFICATION=C       

time zone: Europe/Copenhagen
tzcode source: system (glibc)

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] testthat_3.2.3 rlang_1.1.6   

loaded via a namespace (and not attached):
 [1] crayon_1.5.3      vctrs_0.6.5       cli_3.6.4         knitr_1.50       
 [5] xfun_0.52         pkgload_1.4.0     diffobj_0.3.5     glue_1.8.0       
 [9] rprojroot_2.0.4   htmltools_0.5.8.1 pkgbuild_1.4.7    brio_1.1.5       
[13] rmarkdown_2.29    evaluate_1.0.3    tibble_3.2.1      fastmap_1.2.0    
[17] lifecycle_1.0.4   compiler_4.5.0    pkgconfig_2.0.3   waldo_0.6.1      
[21] rstudioapi_0.17.1 digest_0.6.37     R6_2.6.1          pillar_1.10.2    
[25] magrittr_2.0.3    tools_4.5.0       withr_3.0.2       desc_1.4.3       
> q()
Save workspace image? [y/n/c]: n
$

MichaelChirico · 2025-04-21T19:58:42Z

Thanks; see the linked CL

musvaage · 2025-04-21T20:21:28Z

off-topic

tests/testthat/test-deparse.R

line 265 may have a typo

predecence

maybe I'll fix that in a bulk code comment typo fix

superfluous information

R version 4.5.0 with solely installed packages as testthat and dependencies.

library(rlang)
library(testthat)
test_dir("tests")

After entering the above at the R prompt here's the end of the output of sessionInfo().

loaded via a namespace (and not attached):
 [1] desc_1.4.3      waldo_0.6.1     R6_2.6.1        diffobj_0.3.6  
 [5] magrittr_2.0.3  glue_1.8.0      lifecycle_1.0.4 cli_3.6.5      
 [9] withr_3.0.2     pkgload_1.4.0   compiler_4.5.0  rprojroot_2.0.4
[13] tools_4.5.0     pkgbuild_1.4.7  brio_1.1.5      evaluate_1.0.3 
[17] crayon_1.5.3

MichaelChirico linked a pull request Apr 21, 2025 that will close this issue

Make pillar dependency explicit in expr_deparse() output tests #1796

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Unstated pillar version requirement? #1794

Unstated pillar version requirement? #1794

MichaelChirico commented Apr 18, 2025 •

edited

Loading

musvaage commented Apr 21, 2025

Uh oh!

MichaelChirico commented Apr 21, 2025

Uh oh!

musvaage commented Apr 21, 2025

Uh oh!

musvaage commented Apr 21, 2025

Uh oh!

MichaelChirico commented Apr 21, 2025

Uh oh!

MichaelChirico commented Apr 21, 2025

Uh oh!

musvaage commented Apr 21, 2025 •

edited

Loading

Uh oh!

MichaelChirico commented Apr 21, 2025

Uh oh!

musvaage commented Apr 21, 2025 •

edited

Loading

Uh oh!

Unstated pillar version requirement? #1794

Unstated pillar version requirement? #1794

Comments

MichaelChirico commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

musvaage commented Apr 21, 2025

Uh oh!

MichaelChirico commented Apr 21, 2025

Uh oh!

musvaage commented Apr 21, 2025

Uh oh!

musvaage commented Apr 21, 2025

Uh oh!

MichaelChirico commented Apr 21, 2025

Uh oh!

MichaelChirico commented Apr 21, 2025

Uh oh!

musvaage commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelChirico commented Apr 21, 2025

Uh oh!

musvaage commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelChirico commented Apr 18, 2025 •

edited

Loading

musvaage commented Apr 21, 2025 •

edited

Loading

musvaage commented Apr 21, 2025 •

edited

Loading